Issue 167113004: Explicitly provide path to C built-in includes in libc++ builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 167113004: Explicitly provide path to C built-in includes in libc++ builds. (Closed)

Created:
6 years, 10 months ago by earthdok

Modified:
6 years, 10 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Explicitly provide path to C built-in includes in libc++ builds. Temporary workaround for a goma bug. BUG=337426 TBR=glider@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251365

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -1 line)			Patch
	M	third_party/libc++/libc++.gyp	View		2 chunks	+6 lines, -0 lines	0 comments	Download
	M	third_party/libc++abi/libc++abi.gyp	View		2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

earthdok

Committed patchset #1 manually as r251365 (presubmit successful).

6 years, 10 months ago (2014-02-14 17:36:14 UTC) #2

Alexander Potapenko

6 years, 10 months ago (2014-02-17 14:36:58 UTC) #3

LGTM

On Fri, Feb 14, 2014 at 9:36 AM,  <earthdok@chromium.org> wrote:
> Committed patchset #1 manually as r251365 (presubmit successful).
>
> https://codereview.chromium.org/167113004/

-- 
Alexander Potapenko
Software Engineer
Google Moscow

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Expand Messages | Collapse Messages