Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1671123002: Dropping ncbray from nacl OWNERS :-( (Closed)

Created:
4 years, 10 months ago by bradnelson
Modified:
4 years, 10 months ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Dropping ncbray from nacl OWNERS :-( BUG=None TEST=None R=ncbray@chromium.org Committed: https://crrev.com/82c760211d465e7ec72290c477ce2ded3a6db72e Cr-Commit-Position: refs/heads/master@{#373930}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -159 lines) Patch
M chrome/test/data/nacl/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/nacl/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/nacl_test_injection/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/native_client/OWNERS View 1 chunk +1 line, -6 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 35 chunks +100 lines, -150 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
bradn
4 years, 10 months ago (2016-02-05 18:12:12 UTC) #2
Nick Bray (chromium)
LGTM
4 years, 10 months ago (2016-02-05 18:17:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1671123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1671123002/1
4 years, 10 months ago (2016-02-05 18:18:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/143150)
4 years, 10 months ago (2016-02-05 18:31:32 UTC) #7
Alexei Svitkine (slow)
lgtm
4 years, 10 months ago (2016-02-05 19:08:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1671123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1671123002/1
4 years, 10 months ago (2016-02-05 19:09:53 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/19103)
4 years, 10 months ago (2016-02-05 20:16:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1671123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1671123002/1
4 years, 10 months ago (2016-02-05 21:28:27 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-05 22:46:30 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 22:47:27 UTC) #18
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/82c760211d465e7ec72290c477ce2ded3a6db72e
Cr-Commit-Position: refs/heads/master@{#373930}

Powered by Google App Engine
This is Rietveld 408576698