Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(34)

Issue 1671113002: Remove CFX_FileSizeArray. (Closed)

Created:
4 years, 8 months ago by Tom Sepez
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : Simple replacement, no optimizations. #

Patch Set 2 : Make m_SortedOffset a set #

Patch Set 3 : Nits. #

Total comments: 5

Patch Set 4 : Remove m_CrossOffset. #

Patch Set 5 : Add size_t cast #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -226 lines) Patch
M core/include/fpdfapi/fpdf_parser.h View 1 2 3 chunks +9 lines, -11 lines 0 comments Download
M core/include/fxcrt/fx_basic.h View 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 2 3 4 33 chunks +86 lines, -211 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/parser_int.h View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Tom Sepez
Lei, for review.
4 years, 8 months ago (2016-02-05 19:07:17 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1671113002/diff/40001/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right): https://codereview.chromium.org/1671113002/diff/40001/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp#newcode372 core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:372: // SLOW ... You could push_back() and then ...
4 years, 8 months ago (2016-02-05 19:22:20 UTC) #3
Tom Sepez
https://codereview.chromium.org/1671113002/diff/40001/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right): https://codereview.chromium.org/1671113002/diff/40001/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp#newcode372 core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:372: // SLOW ... On 2016/02/05 19:22:20, Lei Zhang wrote: ...
4 years, 8 months ago (2016-02-05 21:03:02 UTC) #4
Lei Zhang
https://codereview.chromium.org/1671113002/diff/40001/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right): https://codereview.chromium.org/1671113002/diff/40001/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp#newcode372 core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:372: // SLOW ... On 2016/02/05 21:03:02, Tom Sepez wrote: ...
4 years, 8 months ago (2016-02-05 21:09:56 UTC) #5
Tom Sepez
4 years, 8 months ago (2016-02-05 21:17:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
360bc5ffb58e001dc7694967d79b29d54a935337 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698