Remove CFX_FileSizeArray.

Remove CFX_FileSizeArray.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/360bc5ffb58e001dc7694967d79b29d54a935337

[Tom Sepez, 2016-02-05 19:07:16]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-02-05 19:07:17]

Lei, for review.

[Lei Zhang, 2016-02-05 19:22:20]

lgtm

https://codereview.chromium.org/1671113002/diff/40001/core/src/fpdfapi/fpdf_p...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right):

https://codereview.chromium.org/1671113002/diff/40001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:372: // SLOW ...
You could push_back() and then iterate through the vector in reverse?

https://codereview.chromium.org/1671113002/diff/40001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:3690:
m_CrossOffset.insert(m_CrossOffset.begin(), m_dwXRefOffset);
BTW, we insert into |m_crossoffset| but never read from it.

[Tom Sepez, 2016-02-05 21:03:02]

https://codereview.chromium.org/1671113002/diff/40001/core/src/fpdfapi/fpdf_p...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right):

https://codereview.chromium.org/1671113002/diff/40001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:372: // SLOW ...
On 2016/02/05 19:22:20, Lei Zhang wrote:
> You could push_back() and then iterate through the vector in reverse?
Nah, the fix is to make it a deque, if I can prove the underlying data need not
be contiguous

https://codereview.chromium.org/1671113002/diff/40001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:3690:
m_CrossOffset.insert(m_CrossOffset.begin(), m_dwXRefOffset);
On 2016/02/05 19:22:20, Lei Zhang wrote:
> BTW, we insert into |m_crossoffset| but never read from it.

Removed.

[Lei Zhang, 2016-02-05 21:09:56]

https://codereview.chromium.org/1671113002/diff/40001/core/src/fpdfapi/fpdf_p...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right):

https://codereview.chromium.org/1671113002/diff/40001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:372: // SLOW ...
On 2016/02/05 21:03:02, Tom Sepez wrote:
> On 2016/02/05 19:22:20, Lei Zhang wrote:
> > You could push_back() and then iterate through the vector in reverse?
> Nah, the fix is to make it a deque, if I can prove the underlying data need
not
> be contiguous

I was thinking about a deque too, but I realized we are always inserting at the
beginning. In practice, contiguous memory may be good for locality / caching, or
maybe this doesn't really matter in the larger scheme of things.

[Tom Sepez, 2016-02-05 21:17:25]

Description was changed from

==========
Remove CFX_FileSizeArray.
==========

to

==========
Remove CFX_FileSizeArray.

R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/360bc5ffb58e001dc7694967d79b29d54a93...
==========

[Tom Sepez, 2016-02-05 21:17:26]

Committed patchset #5 (id:80001) manually as
360bc5ffb58e001dc7694967d79b29d54a935337 (presubmit successful).