third_party/WebKit/Source/core/input/EventHandler.cpp - Issue 1671103002: Prevent remaining keypress actions if textInput was canceled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/input/EventHandler.cpp

Issue 1671103002: Prevent remaining keypress actions if textInput was canceled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added layout test Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/events/space-scroll-textinput-canceled.html ('K') | « third_party/WebKit/LayoutTests/fast/events/space-scroll-textinput-canceled-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/input/EventHandler.cpp

diff --git a/third_party/WebKit/Source/core/input/EventHandler.cpp b/third_party/WebKit/Source/core/input/EventHandler.cpp

index 5ec337e655cfa8a1cfe03b4df1cb535a050dfb01..dbab84518033fb7b5b6614555ed29859e78127fb 100644

--- a/third_party/WebKit/Source/core/input/EventHandler.cpp

+++ b/third_party/WebKit/Source/core/input/EventHandler.cpp

@@ -3555,7 +3555,7 @@ bool EventHandler::handleTextInputEvent(const String& text, Event* underlyingEve

event->setUnderlyingEvent(underlyingEvent);

target->dispatchEvent(event);

- return event->defaultHandled();

+ return event->defaultHandled() || event->defaultPrevented();

}

void EventHandler::defaultTextInputEventHandler(TextEvent* event)