Prevent remaining keypress actions if textInput was canceled

Return true if the 'textInput' event was handled by Chrome or event listeners to match Edge's behaviour.

Might affect some EditorCommand but they are either Chrome only or
supportedFromMenuOrKeyBinding().

BUG=355103
Committed: https://crrev.com/a3422513370fbca5b3bc2cfb5a4962692552b672
Cr-Commit-Position: refs/heads/master@{#374251}

[chongz, 2016-02-05 19:54:46]

chongz@chromium.org changed reviewers:
+ dtapuska@chromium.org

[chongz, 2016-02-05 19:54:47]

Can I have a review please? Thanks!

[dtapuska, 2016-02-05 20:00:36]

On 2016/02/05 19:54:47, chongz wrote:
> Can I have a review please? Thanks!

Can we write a layout test for this?

[chongz, 2016-02-08 13:45:39]

Can I have a review on the layout test please? Thanks!

[dtapuska, 2016-02-08 13:50:07]

https://codereview.chromium.org/1671103002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/events/space-scroll-textinput-canceled.html
(right):

https://codereview.chromium.org/1671103002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/events/space-scroll-textinput-canceled.html:41:
}, 10);
Is this reliable? Should we instead register for a RAF?

Should we check that a keypress wasn't generated? Instead?

[chongz, 2016-02-08 16:17:53]

Updated layout test. The logic now is to do a pageUp first then press space key
immediately, and pageUp shouldn't get canceled.

[dtapuska, 2016-02-08 16:23:52]

On 2016/02/08 16:17:53, chongz wrote:
> Updated layout test. The logic now is to do a pageUp first then press space
key
> immediately, and pageUp shouldn't get canceled.

lgtm

[chongz, 2016-02-08 17:47:31]

Description was changed from

==========
Prevent remaining keypress actions if textInput was canceled

Also return true if textInput event is defaultPrevented() in
EventHandler::handleTextInputEvent() to match Edge's behaviour.

Might affect some EditorCommand but they are either Chrome only or
supportedFromMenuOrKeyBinding().

BUG=355103
==========

to

==========
Return true if the 'textInput' event was handled by Chrome or event listeners to
match Edge's behaviour.

Might affect some EditorCommand but they are either Chrome only or
supportedFromMenuOrKeyBinding().

BUG=355103
==========

[chongz, 2016-02-08 17:48:05]

chongz@chromium.org changed reviewers:
+ skobes@chromium.org

[chongz, 2016-02-08 17:48:06]

Hi skobes, can I have a review on the CL please? Thanks!

[skobes, 2016-02-08 23:17:26]

lgtm

[chongz, 2016-02-08 23:18:13]

The CQ bit was checked by chongz@chromium.org

[commit-bot: I haz the power, 2016-02-08 23:20:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1671103002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1671103002/40001

[commit-bot: I haz the power, 2016-02-09 01:18:15]

Description was changed from

==========
Return true if the 'textInput' event was handled by Chrome or event listeners to
match Edge's behaviour.

Might affect some EditorCommand but they are either Chrome only or
supportedFromMenuOrKeyBinding().

BUG=355103
==========

to

==========
Return true if the 'textInput' event was handled by Chrome or event listeners to
match Edge's behaviour.

Might affect some EditorCommand but they are either Chrome only or
supportedFromMenuOrKeyBinding().

BUG=355103
==========

[commit-bot: I haz the power, 2016-02-09 01:18:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-09 01:19:36]

Description was changed from

==========
Return true if the 'textInput' event was handled by Chrome or event listeners to
match Edge's behaviour.

Might affect some EditorCommand but they are either Chrome only or
supportedFromMenuOrKeyBinding().

BUG=355103
==========

to

==========
Return true if the 'textInput' event was handled by Chrome or event listeners to
match Edge's behaviour.

Might affect some EditorCommand but they are either Chrome only or
supportedFromMenuOrKeyBinding().

BUG=355103

Committed: https://crrev.com/a3422513370fbca5b3bc2cfb5a4962692552b672
Cr-Commit-Position: refs/heads/master@{#374251}
==========

[commit-bot: I haz the power, 2016-02-09 01:19:37]

Patchset 3 (id:??) landed as
https://crrev.com/a3422513370fbca5b3bc2cfb5a4962692552b672
Cr-Commit-Position: refs/heads/master@{#374251}