pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart - Issue 1671073002: dart2js cps: Pull SetFields into field initializer arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart

Issue 1671073002: dart2js cps: Pull SetFields into field initializer arguments. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Fix accidental lifting of LetConts instead of sinking Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart

diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart

index db1592db3216b5064fdcdb6cb4ef381eeb0ca0f7..f8d899751f12564c61f9fd01a3c2dadd1c8795fd 100644

--- a/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart

+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart

@@ -11,7 +11,7 @@ import '../tracer.dart';

/**

* If true, show LetCont expressions in output.

-const bool IR_TRACE_LET_CONT = false;

+const bool IR_TRACE_LET_CONT = true;

Siggi Cherem (dart-lang) 2016/02/08 19:26:44 was this supposed to be temporary while debugging?

asgerf 2016/02/09 09:29:07 Changed to false again.

class IRTracer extends TracerUtil implements cps_ir.Visitor {

EventSink<String> output;