pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart - Issue 1671073002: dart2js cps: Pull SetFields into field initializer arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

Issue 1671073002: dart2js cps: Pull SetFields into field initializer arguments. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Fix accidental lifting of LetConts instead of sinking Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

index 37dc74b9d18c41776c02584a3b20fefbd0e0194d..d4fb62ffd33c4c0f5e9d4b5a7153f0eacf38f188 100644

--- a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

@@ -430,7 +430,7 @@ class IrBuilderVisitor extends ast.Visitor<ir.Primitive>

/// Maps each field from this class or a superclass to its initial value.

Map<FieldElement, ir.Primitive> fieldValues =

- <FieldElement, ir.Primitive>{};

+ <FieldElement, ir.Primitive>{};

// -- Evaluate field initializers ---

// Evaluate field initializers in constructor and super constructors.