dart2js cps: Pull SetFields into field initializer arguments.

dart2js cps: Pull SetFields into field initializer arguments.

For example:

    foo = new D.Foo(null, null);
    foo.x = 'a';
    foo.y = 'b';

becomes:

    foo = new D.Foo('a', 'b');

BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/86f286a3eb9f4e8a5a0041e1521d4f83db855aaa

[asgerf, 2016-02-05 16:38:48]

asgerf@google.com changed reviewers:
+ kmillikin@google.com, sigmund@google.com

[Siggi Cherem (dart-lang), 2016-02-05 18:46:39]

lgtm - maybe add a unittest that validates the transformation?

https://codereview.chromium.org/1671073002/diff/1/pkg/compiler/lib/src/cps_ir...
File pkg/compiler/lib/src/cps_ir/use_field_initializers.dart (right):

https://codereview.chromium.org/1671073002/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/use_field_initializers.dart:121: // of the object
before this, so the old value cannot have been seen.
I'm assuming it doesn't matter if the old value is non-null, right?

So something like this:

  var x = new A(null);
  x.f = foo(); // prints & creates something
  x.f = foo();

Becomes:

  foo()
  var x = new A(foo());
?

[asgerf, 2016-02-08 18:46:46]

PTAL.

There was a bug with fields on native classes, and with LetConts getting lifted
in some cases, causing references to fall out of scope.

https://codereview.chromium.org/1671073002/diff/1/pkg/compiler/lib/src/cps_ir...
File pkg/compiler/lib/src/cps_ir/use_field_initializers.dart (right):

https://codereview.chromium.org/1671073002/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/use_field_initializers.dart:121: // of the object
before this, so the old value cannot have been seen.
On 2016/02/05 18:46:39, Siggi Cherem (dart-lang) wrote:
> I'm assuming it doesn't matter if the old value is non-null, right?
> 
> So something like this:
> 
>   var x = new A(null);
>   x.f = foo(); // prints & creates something
>   x.f = foo();
> 
> Becomes:
> 
>   foo()
>   var x = new A(foo());
> ?

That's right.

[Siggi Cherem (dart-lang), 2016-02-08 19:26:44]

lgtm

https://codereview.chromium.org/1671073002/diff/60001/pkg/compiler/lib/src/cp...
File pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart (right):

https://codereview.chromium.org/1671073002/diff/60001/pkg/compiler/lib/src/cp...
pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart:14: const bool IR_TRACE_LET_CONT
= true;
was this supposed to be temporary while debugging? Or do you want to turn it on
by default?

[asgerf, 2016-02-09 09:29:07]

https://codereview.chromium.org/1671073002/diff/60001/pkg/compiler/lib/src/cp...
File pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart (right):

https://codereview.chromium.org/1671073002/diff/60001/pkg/compiler/lib/src/cp...
pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart:14: const bool IR_TRACE_LET_CONT
= true;
On 2016/02/08 19:26:44, Siggi Cherem (dart-lang) wrote:
> was this supposed to be temporary while debugging? Or do you want to turn it
on
> by default?

Changed to false again.

[asgerf, 2016-02-09 11:33:22]

Description was changed from

==========
dart2js cps: Pull SetFields into field initializer arguments.

For example:

    foo = new D.Foo(null, null);
    foo.x = 'a';
    foo.y = 'b';

becomes:

    foo = new D.Foo('a', 'b');

BUG=
==========

to

==========
dart2js cps: Pull SetFields into field initializer arguments.

For example:

    foo = new D.Foo(null, null);
    foo.x = 'a';
    foo.y = 'b';

becomes:

    foo = new D.Foo('a', 'b');

BUG=
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/86f286a3eb9f4e8a5a0041e1521d4f83db855aaa
==========

[asgerf, 2016-02-09 11:33:24]

Committed patchset #5 (id:80001) manually as
86f286a3eb9f4e8a5a0041e1521d4f83db855aaa (presubmit successful).