Enable deferred free for syzyasan builds behind a feature.

Enable deferred free for syzyasan builds behind a feature.

This feature will (hopefully) improve the performance of Syzyasan builds.

BUG=

Committed: https://crrev.com/88103a11c77bc1f5573b59e852cc032bae36d509
Cr-Commit-Position: refs/heads/master@{#381862}

[Georges Khalil, 2016-03-09 22:28:01]

Patchset #1 (id:1) has been deleted

[Georges Khalil, 2016-03-09 22:28:46]

georgesak@chromium.org changed reviewers:
+ chrisha@chromium.org

[Georges Khalil, 2016-03-09 22:28:47]

Chris, PTAL.

[Georges Khalil, 2016-03-10 18:24:22]

Description was changed from

==========
Add setting deffered free for syzyasan builds behind a feature.

BUG=
==========

to

==========
Enable deferred free for syzyasan builds behind a feature.

This feature will (hopefully) improve the performance of Syzyasan builds.

BUG=
==========

[Georges Khalil, 2016-03-17 18:26:01]

On 2016/03/09 22:28:47, Georges Khalil wrote:
> Chris, PTAL.

Ping? Let's get in soon so we can be ready.

[chrisha, 2016-03-17 18:35:28]

lgtm with nits

https://codereview.chromium.org/1671063002/diff/20001/chrome/browser/chrome_b...
File chrome/browser/chrome_browser_main.cc (right):

https://codereview.chromium.org/1671063002/diff/20001/chrome/browser/chrome_b...
chrome/browser/chrome_browser_main.cc:1192: HMODULE SyzyasanModuleHandle =
::GetModuleHandle(L"syzyasan_rtl.dll");
euhh... snake_style variable names instead of CamelCase?

https://codereview.chromium.org/1671063002/diff/20001/chrome/browser/chrome_b...
chrome/browser/chrome_browser_main.cc:1195: SyzyasanEnableDeferredFreeThreadFunc
EnableDeferredFreeThread =
ditto

[Georges Khalil, 2016-03-17 19:34:39]

georgesak@chromium.org changed reviewers:
+ rkaplow@chromium.org

[Georges Khalil, 2016-03-17 19:34:40]

rkaplow@, PTAL for Features API + histograms.

https://codereview.chromium.org/1671063002/diff/20001/chrome/browser/chrome_b...
File chrome/browser/chrome_browser_main.cc (right):

https://codereview.chromium.org/1671063002/diff/20001/chrome/browser/chrome_b...
chrome/browser/chrome_browser_main.cc:1192: HMODULE SyzyasanModuleHandle =
::GetModuleHandle(L"syzyasan_rtl.dll");
Oops, I was looking at Windows code for too long :S

Done.

https://codereview.chromium.org/1671063002/diff/20001/chrome/browser/chrome_b...
chrome/browser/chrome_browser_main.cc:1195: SyzyasanEnableDeferredFreeThreadFunc
EnableDeferredFreeThread =
On 2016/03/17 18:35:28, chrisha wrote:
> ditto

Done.

[rkaplow, 2016-03-17 20:18:01]

lgtm

[Georges Khalil, 2016-03-17 20:19:07]

sky@, PTAL in chrome/* for owner approval.

[Georges Khalil, 2016-03-17 20:20:24]

georgesak@chromium.org changed reviewers:
+ sky@chromium.org

[Georges Khalil, 2016-03-17 20:20:25]

Oops, forgot to actually add sky@!

sky@, PTAL in chrome/* for owner approval.

[sky, 2016-03-17 23:22:52]

LGTM

[Georges Khalil, 2016-03-17 23:32:55]

The CQ bit was checked by georgesak@chromium.org

[Georges Khalil, 2016-03-17 23:32:56]

The patchset sent to the CQ was uploaded after l-g-t-m from chrisha@chromium.org
Link to the patchset: https://codereview.chromium.org/1671063002/#ps60001
(title: "Add extra comment.")

[commit-bot: I haz the power, 2016-03-17 23:33:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1671063002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1671063002/60001

[commit-bot: I haz the power, 2016-03-17 23:35:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 23:35:46]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Georges Khalil, 2016-03-17 23:55:31]

The CQ bit was checked by georgesak@chromium.org

[Georges Khalil, 2016-03-17 23:55:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrisha@chromium.org, rkaplow@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1671063002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-03-17 23:56:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1671063002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1671063002/80001

[commit-bot: I haz the power, 2016-03-18 01:17:49]

Description was changed from

==========
Enable deferred free for syzyasan builds behind a feature.

This feature will (hopefully) improve the performance of Syzyasan builds.

BUG=
==========

to

==========
Enable deferred free for syzyasan builds behind a feature.

This feature will (hopefully) improve the performance of Syzyasan builds.

BUG=
==========

[commit-bot: I haz the power, 2016-03-18 01:17:50]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-03-18 01:19:11]

Description was changed from

==========
Enable deferred free for syzyasan builds behind a feature.

This feature will (hopefully) improve the performance of Syzyasan builds.

BUG=
==========

to

==========
Enable deferred free for syzyasan builds behind a feature.

This feature will (hopefully) improve the performance of Syzyasan builds.

BUG=

Committed: https://crrev.com/88103a11c77bc1f5573b59e852cc032bae36d509
Cr-Commit-Position: refs/heads/master@{#381862}
==========

[commit-bot: I haz the power, 2016-03-18 01:19:12]

Patchset 4 (id:??) landed as
https://crrev.com/88103a11c77bc1f5573b59e852cc032bae36d509
Cr-Commit-Position: refs/heads/master@{#381862}