sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart - Issue 167103003: Support serving from multiple directories using "pub serve".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart

Issue 167103003: Support serving from multiple directories using "pub serve". (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/pub/lib/src/barback/build_environment.dart ('K') | « sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart ('k') | sdk/lib/_internal/pub/lib/src/barback/server.dart » ('j') | sdk/lib/_internal/pub/lib/src/command.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart

diff --git a/sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart b/sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart

index 30aefdee9abfdfb7f65a873e5b99536546e868d5..f4f871645600b92559d3137caeef9fe3db3861e6 100644

--- a/sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart

+++ b/sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart

@@ -366,8 +366,8 @@ Future<Set> loadTransformers(BuildEnvironment environment, TransformerId id) {

return id.getAssetId(environment.barback).then((assetId) {

var path = assetId.path.replaceFirst('lib/', '');

// TODO(nweiz): load from a "package:" URI when issue 12474 is fixed.

- var baseUrl = baseUrlForAddress(environment.server.address,

- environment.server.port);

+ var baseUrl = baseUrlForAddress(environment.servers.first.address,

+ environment.servers.first.port);

Bob Nystrom 2014/02/19 00:36:52 Document why using .first is OK.

nweiz 2014/02/19 01:25:58 Done.

var uri = '$baseUrl/packages/${id.package}/$path';

var code = 'import "$uri";\n' +

_TRANSFORMER_ISOLATE.replaceAll('<<URL_BASE>>', baseUrl);