Issue 1671013002: Add '--abort-on-assertion-errors' to test runner's dart2js commands.

Issue 1671013002: Add '--abort-on-assertion-errors' to test runner's dart2js commands. (Closed)

Created:
4 years, 10 months ago by Bill Hesse

Modified:
4 years, 10 months ago

Reviewers:
Vyacheslav Egorov (Google), kustermann

CC:
reviews_dartlang.org, ricow1

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Add '--abort-on-assertion-errors' to test runner's dart2js commands. BUG=https://github.com/dart-lang/sdk/issues/25645 R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/a8e54625dadf91676f19ed3278b68824ff66f294

Total comments: 2

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
	M	tools/testing/dart/compiler_configuration.dart	View		1 chunk	+12 lines, -1 line	2 comments	Download

Total messages: 6 (2 generated)

Bill Hesse

The changed function is in the DartToXCompilerConfiguration class, so it changes all dart2js compilers created ...

4 years, 10 months ago (2016-02-05 13:27:19 UTC) #2

kustermann

LGTM Do the dart2js builders: * set ulimit -c unlimited * archive binaries and coredumps ...

4 years, 10 months ago (2016-02-08 11:11:42 UTC) #3

Bill Hesse

The next step is to capture and archive the coredumps: Do the dart2js builders: * ...

4 years, 10 months ago (2016-02-08 11:16:10 UTC) #4

Bill Hesse

4 years, 10 months ago (2016-02-08 16:27:03 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a8e54625dadf91676f19ed3278b68824ff66f294 (presubmit successful).