[bootstrapper] extra natives must not use natives syntax.

[bootstrapper] extra natives must not use natives syntax.

R=bmeurer@chromium.org, domenic@chromium.org

Committed: https://crrev.com/8a2d571734f77484b75639bf4455a5abb5f7442a
Cr-Commit-Position: refs/heads/master@{#33770}

[Benedikt Meurer, 2016-02-05 06:55:25]

LGTM.

[Yang, 2016-02-05 08:37:33]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-02-05 08:37:33]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1670923003/#ps20001
(title: "hide source and stack trace")

[commit-bot: I haz the power, 2016-02-05 08:37:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1670923003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1670923003/20001

[commit-bot: I haz the power, 2016-02-05 08:51:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-05 08:51:46]

Try jobs failed on following builders:
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/13351)

[Yang, 2016-02-05 08:59:12]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-02-05 08:59:12]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1670923003/#ps40001
(title: "fix test")

[commit-bot: I haz the power, 2016-02-05 08:59:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1670923003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1670923003/40001

[commit-bot: I haz the power, 2016-02-05 09:14:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-05 09:14:47]

Try jobs failed on following builders:
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/13353)

[Yang, 2016-02-05 12:10:50]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-02-05 12:10:50]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1670923003/#ps60001
(title: "fix test")

[commit-bot: I haz the power, 2016-02-05 12:11:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1670923003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1670923003/60001

[commit-bot: I haz the power, 2016-02-05 12:33:24]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-05 12:34:06]

Description was changed from

==========
[bootstrapper] extra natives must not use natives syntax.

R=bmeurer@chromium.org, domenic@chromium.org
==========

to

==========
[bootstrapper] extra natives must not use natives syntax.

R=bmeurer@chromium.org, domenic@chromium.org

Committed: https://crrev.com/8a2d571734f77484b75639bf4455a5abb5f7442a
Cr-Commit-Position: refs/heads/master@{#33770}
==========

[commit-bot: I haz the power, 2016-02-05 12:34:07]

Patchset 4 (id:??) landed as
https://crrev.com/8a2d571734f77484b75639bf4455a5abb5f7442a
Cr-Commit-Position: refs/heads/master@{#33770}

[domenic, 2016-02-05 19:00:27]

Thanks for taking care of this Yang!

This also means no % functions, right? I didn't see a test for that, although I
assume it's harder to test. Just wanted to confirm so that I can knock that off
my to-do list.

https://codereview.chromium.org/1670923003/diff/60001/src/globals.h
File src/globals.h (right):

https://codereview.chromium.org/1670923003/diff/60001/src/globals.h#newcode532
src/globals.h:532: enum NativesFlag { NOT_NATIVES_CODE, EXTENSION_CODE,
NATIVES_CODE };
Should it be EXTRAS_CODE?

[Yang, 2016-02-05 19:04:58]

On 2016/02/05 19:00:27, domenic wrote:
> Thanks for taking care of this Yang!
> 
> This also means no % functions, right? I didn't see a test for that, although
I
> assume it's harder to test. Just wanted to confirm so that I can knock that
off
> my to-do list.

Correct. Unfortunately, without natives syntax, %Function causes an early syntax
error, so there is no way to test this without breaking the entire build.

> 
> https://codereview.chromium.org/1670923003/diff/60001/src/globals.h
> File src/globals.h (right):
> 
> https://codereview.chromium.org/1670923003/diff/60001/src/globals.h#newcode532
> src/globals.h:532: enum NativesFlag { NOT_NATIVES_CODE, EXTENSION_CODE,
> NATIVES_CODE };
> Should it be EXTRAS_CODE?

This is intentional. I realized that we were not doing the right thing for
extensions either. We essentially have three kinds of code:
- native code, where we have natives syntax (%Function), hide the source and
stack frames from stack traces.
- user code, where we do not have natives syntax, do not hide the source and
stack frames show up in the stack trace.
- extension and extras code, where we do not have natives syntax, but hide the
source and stack frames.

Since extras and extensions do not differ in this regard, I just lumped them
together.