Issue 1670843002: Fix tests under no_v8 build option

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1670843002: Fix tests under no_v8 build option (Closed)

Created:
4 years, 10 months ago by Tom Sepez

Modified:
4 years, 10 months ago

Reviewers:
Lei Zhang, Oliver Chang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	M	fpdfsdk/src/fpdfformfill_embeddertest.cpp	View		2 chunks	+2 lines, -0 lines	0 comments	Download
	M	testing/SUPPRESSIONS	View		3 chunks	+13 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

TBR, try again, this time land it to master, not XFA. Old habits die hard.

4 years, 10 months ago (2016-02-05 00:53:07 UTC) #1

Tom Sepez

Committed patchset #1 (id:1) manually as 4d0717934b7146a0fec7462ba131bd33f5dc246a (tree was closed).

4 years, 10 months ago (2016-02-05 00:53:29 UTC) #3

Message was sent while issue was closed.

Whoops, lgtm