Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 1670813005: Revert of Type Feedback Vector lives in the closure (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/factory.cc ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 1204 matching lines...) Expand 10 before | Expand all | Expand 10 after
1215 1215
1216 1216
1217 void FullCodeGenerator::EmitNewClosure(Handle<SharedFunctionInfo> info, 1217 void FullCodeGenerator::EmitNewClosure(Handle<SharedFunctionInfo> info,
1218 bool pretenure) { 1218 bool pretenure) {
1219 // Use the fast case closure allocation code that allocates in new 1219 // Use the fast case closure allocation code that allocates in new
1220 // space for nested functions that don't need literals cloning. If 1220 // space for nested functions that don't need literals cloning. If
1221 // we're running with the --always-opt or the --prepare-always-opt 1221 // we're running with the --always-opt or the --prepare-always-opt
1222 // flag, we need to use the runtime function so that the new function 1222 // flag, we need to use the runtime function so that the new function
1223 // we are creating here gets a chance to have its code optimized and 1223 // we are creating here gets a chance to have its code optimized and
1224 // doesn't just get a copy of the existing unoptimized code. 1224 // doesn't just get a copy of the existing unoptimized code.
1225 if (!FLAG_always_opt && !FLAG_prepare_always_opt && !pretenure && 1225 if (!FLAG_always_opt &&
1226 scope()->is_function_scope()) { 1226 !FLAG_prepare_always_opt &&
1227 !pretenure &&
1228 scope()->is_function_scope() &&
1229 info->num_literals() == 0) {
1227 FastNewClosureStub stub(isolate(), info->language_mode(), info->kind()); 1230 FastNewClosureStub stub(isolate(), info->language_mode(), info->kind());
1228 __ mov(r2, Operand(info)); 1231 __ mov(r2, Operand(info));
1229 __ CallStub(&stub); 1232 __ CallStub(&stub);
1230 } else { 1233 } else {
1231 __ Push(info); 1234 __ Push(info);
1232 __ CallRuntime(pretenure ? Runtime::kNewClosure_Tenured 1235 __ CallRuntime(pretenure ? Runtime::kNewClosure_Tenured
1233 : Runtime::kNewClosure); 1236 : Runtime::kNewClosure);
1234 } 1237 }
1235 context()->Plug(r0); 1238 context()->Plug(r0);
1236 } 1239 }
(...skipping 3606 matching lines...) Expand 10 before | Expand all | Expand 10 after
4843 DCHECK(interrupt_address == 4846 DCHECK(interrupt_address ==
4844 isolate->builtins()->OsrAfterStackCheck()->entry()); 4847 isolate->builtins()->OsrAfterStackCheck()->entry());
4845 return OSR_AFTER_STACK_CHECK; 4848 return OSR_AFTER_STACK_CHECK;
4846 } 4849 }
4847 4850
4848 4851
4849 } // namespace internal 4852 } // namespace internal
4850 } // namespace v8 4853 } // namespace v8
4851 4854
4852 #endif // V8_TARGET_ARCH_ARM 4855 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/factory.cc ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698