Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Side by Side Diff: src/compiler/js-inlining.cc

Issue 1670813005: Revert of Type Feedback Vector lives in the closure (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/interpreter-assembler.cc ('k') | src/crankshaft/hydrogen.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/js-inlining.h" 5 #include "src/compiler/js-inlining.h"
6 6
7 #include "src/ast/ast.h" 7 #include "src/ast/ast.h"
8 #include "src/ast/ast-numbering.h" 8 #include "src/ast/ast-numbering.h"
9 #include "src/ast/scopes.h" 9 #include "src/ast/scopes.h"
10 #include "src/compiler.h" 10 #include "src/compiler.h"
(...skipping 392 matching lines...) Expand 10 before | Expand all | Expand 10 after
403 TRACE("Not inlining %s into %s because deoptimization support failed\n", 403 TRACE("Not inlining %s into %s because deoptimization support failed\n",
404 function->shared()->DebugName()->ToCString().get(), 404 function->shared()->DebugName()->ToCString().get(),
405 info_->shared_info()->DebugName()->ToCString().get()); 405 info_->shared_info()->DebugName()->ToCString().get());
406 return NoChange(); 406 return NoChange();
407 } 407 }
408 // Remember that we inlined this function. This needs to be called right 408 // Remember that we inlined this function. This needs to be called right
409 // after we ensure deoptimization support so that the code flusher 409 // after we ensure deoptimization support so that the code flusher
410 // does not remove the code with the deoptimization support. 410 // does not remove the code with the deoptimization support.
411 info_->AddInlinedFunction(info.shared_info()); 411 info_->AddInlinedFunction(info.shared_info());
412 412
413 // If function was lazily compiled, it's literals array may not yet be set up.
414 JSFunction::EnsureLiterals(function);
415
416 // ---------------------------------------------------------------- 413 // ----------------------------------------------------------------
417 // After this point, we've made a decision to inline this function. 414 // After this point, we've made a decision to inline this function.
418 // We shall not bailout from inlining if we got here. 415 // We shall not bailout from inlining if we got here.
419 416
420 TRACE("Inlining %s into %s\n", 417 TRACE("Inlining %s into %s\n",
421 function->shared()->DebugName()->ToCString().get(), 418 function->shared()->DebugName()->ToCString().get(),
422 info_->shared_info()->DebugName()->ToCString().get()); 419 info_->shared_info()->DebugName()->ToCString().get());
423 420
424 // TODO(mstarzinger): We could use the temporary zone for the graph because 421 // TODO(mstarzinger): We could use the temporary zone for the graph because
425 // nodes are copied. This however leads to Zone-Types being allocated in the 422 // nodes are copied. This however leads to Zone-Types being allocated in the
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
514 node, frame_state, call.formal_arguments(), 511 node, frame_state, call.formal_arguments(),
515 FrameStateType::kArgumentsAdaptor, info.shared_info()); 512 FrameStateType::kArgumentsAdaptor, info.shared_info());
516 } 513 }
517 514
518 return InlineCall(node, new_target, context, frame_state, start, end); 515 return InlineCall(node, new_target, context, frame_state, start, end);
519 } 516 }
520 517
521 } // namespace compiler 518 } // namespace compiler
522 } // namespace internal 519 } // namespace internal
523 } // namespace v8 520 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/interpreter-assembler.cc ('k') | src/crankshaft/hydrogen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698