third_party/WebKit/Source/platform/heap/PersistentNode.cpp - Issue 1670813004: Avoid data race on CrossThreadPersistents during thread detachment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/PersistentNode.cpp

Issue 1670813004: Avoid data race on CrossThreadPersistents during thread detachment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/heap/PersistentNode.cpp

diff --git a/third_party/WebKit/Source/platform/heap/PersistentNode.cpp b/third_party/WebKit/Source/platform/heap/PersistentNode.cpp

index abd7a1264515f10cbda31c100d1ff52405b54007..fcb060ca55e80643beaec9ba133fc81e5b72332e 100644

--- a/third_party/WebKit/Source/platform/heap/PersistentNode.cpp

+++ b/third_party/WebKit/Source/platform/heap/PersistentNode.cpp

@@ -117,7 +117,7 @@ void CrossThreadPersistentRegion::prepareForThreadStateTermination(ThreadState*

// 'self' is in use, containing the cross-thread persistent wrapper object.

CrossThreadPersistent<GCObject>* persistent = reinterpret_cast<CrossThreadPersistent<GCObject>*>(slots->m_slot[i].self());

ASSERT(persistent);

- void* rawObject = persistent->get();

+ void* rawObject = persistent->atomicGet();

if (!rawObject)

continue;

BasePage* page = pageFromObject(rawObject);

« no previous file with comments | « third_party/WebKit/Source/platform/heap/Handle.h ('k') | no next file » | no next file with comments »