Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: Source/bindings/v8/CustomElementHelpers.h

Issue 16708002: Simplify Custom Element constructors to be functions, not wrappers (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix callback functions as parameters Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/CustomElementHelpers.h
diff --git a/Source/bindings/v8/CustomElementHelpers.h b/Source/bindings/v8/CustomElementHelpers.h
index dcd79e84f5ca78394ef8cbbcab7f57a4dcd7cf6f..dbcb64095de6bed571b696acd96392cfccb4f586 100644
--- a/Source/bindings/v8/CustomElementHelpers.h
+++ b/Source/bindings/v8/CustomElementHelpers.h
@@ -32,6 +32,7 @@
#define CustomElementHelpers_h
#include "bindings/v8/DOMDataStore.h"
+#include "bindings/v8/ScriptState.h"
#include "bindings/v8/ScriptValue.h"
#include "core/dom/CustomElementDefinition.h"
#include "core/dom/CustomElementRegistry.h"
@@ -39,11 +40,12 @@
#include "wtf/Forward.h"
#include "wtf/HashSet.h"
#include "wtf/PassRefPtr.h"
+#include "wtf/text/AtomicString.h"
namespace WebCore {
-class CustomElementConstructor;
class CustomElementInvocation;
+class Document;
class HTMLElement;
class QualifiedName;
class SVGElement;
@@ -51,7 +53,8 @@ class ScriptState;
class CustomElementHelpers {
public:
- static bool initializeConstructorWrapper(CustomElementConstructor*, const ScriptValue& prototype, ScriptState*);
+ static ScriptValue createConstructor(ScriptState*, const ScriptValue& prototype, Document*, const AtomicString& namespaceURI, const AtomicString& name, const AtomicString& type);
+
static bool isValidPrototypeParameter(const ScriptValue&, ScriptState*, AtomicString& namespaceURI);
static bool isValidPrototypeParameter(const ScriptValue&, ScriptState*);
static bool isFeatureAllowed(ScriptState*);

Powered by Google App Engine
This is Rietveld 408576698