Source/core/dom/CustomElementRegistry.h - Issue 16708002: Simplify Custom Element constructors to be functions, not wrappers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/CustomElementRegistry.h

Issue 16708002: Simplify Custom Element constructors to be functions, not wrappers (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/CustomElementRegistry.h

diff --git a/Source/core/dom/CustomElementRegistry.h b/Source/core/dom/CustomElementRegistry.h

index 8b2801f4e379e2bd587aa38b700df0011684a3a5..532f623603ae28b2916507250e4781c561d53f30 100644

--- a/Source/core/dom/CustomElementRegistry.h

+++ b/Source/core/dom/CustomElementRegistry.h

@@ -31,8 +31,8 @@

#ifndef CustomElementRegistry_h

#define CustomElementRegistry_h

+#include "bindings/v8/ScriptValue.h"

#include "core/dom/ContextDestructionObserver.h"

-#include "core/dom/CustomElementConstructor.h"

#include "core/dom/CustomElementUpgradeCandidateMap.h"

#include "core/dom/ExceptionCode.h"

#include "core/dom/QualifiedName.h"

@@ -78,7 +78,7 @@ public:

explicit CustomElementRegistry(Document*);

~CustomElementRegistry();

- PassRefPtr<CustomElementConstructor> registerElement(ScriptState*, const AtomicString& name, const Dictionary& options, ExceptionCode&);

+ ScriptValue registerElement(ScriptState*, const AtomicString& name, const Dictionary& options, ExceptionCode&);

bool isUnresolved(Element*) const;

PassRefPtr<CustomElementDefinition> findFor(Element*) const;