Simplify Custom Element constructors to be functions, not wrappers

Source/bindings/v8/CustomElementHelpers.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 14 matching lines @@
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef CustomElementHelpers_h
 #define CustomElementHelpers_h
 
 #include "bindings/v8/DOMDataStore.h"
+#include "bindings/v8/ScriptState.h"

[haraken, 2013/06/10 09:11:03]

Nit: forward declaration will be enough.

 #include "bindings/v8/ScriptValue.h"
 #include "core/dom/CustomElementDefinition.h"
 #include "core/dom/CustomElementRegistry.h"
 #include "core/dom/Element.h"
 #include "wtf/Forward.h"
 #include "wtf/HashSet.h"
 #include "wtf/PassRefPtr.h"
+#include "wtf/text/AtomicString.h"
 
 namespace WebCore {
 
-class CustomElementConstructor;
 class CustomElementInvocation;
+class Document;
 class HTMLElement;
 class QualifiedName;
 class SVGElement;
 class ScriptState;
 
 class CustomElementHelpers {
 public:
-    static bool initializeConstructorWrapper(CustomElementConstructor*, const ScriptValue& prototype, ScriptState*);
+    static ScriptValue createConstructor(ScriptState*, const ScriptValue& prototype, Document*, const AtomicString& namespaceURI, const AtomicString& name, const AtomicString& type);
+
     static bool isValidPrototypeParameter(const ScriptValue&, ScriptState*, AtomicString& namespaceURI);
     static bool isValidPrototypeParameter(const ScriptValue&, ScriptState*);
     static bool isFeatureAllowed(ScriptState*);
     static const QualifiedName* findLocalName(const ScriptValue& prototype);
 
     static bool isFeatureAllowed(v8::Handle<v8::Context>);
     static WrapperTypeInfo* findWrapperType(v8::Handle<v8::Value> chain);
     static const QualifiedName* findLocalName(v8::Handle<v8::Object> chain);
 
     static void upgradeWrappers(ScriptExecutionContext*, const HashSet<Element*>&, const ScriptValue& prototype);
@@ skipping 40 matching lines @@
 
 inline bool CustomElementHelpers::isValidPrototypeParameter(const ScriptValue& value, ScriptState* state)
 {
     AtomicString namespaceURI;
     return isValidPrototypeParameter(value, state, namespaceURI);
 }
 
 } // namespace WebCore
 
 #endif // CustomElementHelpers_h