components/autofill/core/common/autofill_constants.h - Issue 1670763006: Autofill server-side heuristics for 2 fields password form

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/autofill_constants.h

Issue 1670763006: Autofill server-side heuristics for 2 fields password form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/form_structure_unittest.cc ('k') | components/password_manager/core/browser/password_form_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/autofill_constants.h

diff --git a/components/autofill/core/common/autofill_constants.h b/components/autofill/core/common/autofill_constants.h

index 9c89bddc809dad5c1430d99275022929c320879b..9a1886a92a04e935c77d5bffbe78ce791a43bac3 100644

--- a/components/autofill/core/common/autofill_constants.h

+++ b/components/autofill/core/common/autofill_constants.h

@@ -25,6 +25,10 @@ const size_t kRequiredFieldsForPredictionRoutines = 3;

// servers.

const size_t kRequiredFieldsForUpload = 3;

+// The minimum number of fields in a form that contains only password fields to

+// upload the form to and request predictions from the Autofill servers.

+const size_t kRequiredFieldsForFormsWithOnlyPasswordFields = 2;

// Options bitmask values for AutofillHostMsg_ShowPasswordSuggestions IPC

enum ShowPasswordSuggestionsOptions {

SHOW_ALL = 1 << 0 /* show all credentials, not just ones matching username */,