components/autofill/core/browser/autofill_manager.cc - Issue 1670763006: Autofill server-side heuristics for 2 fields password form

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 1670763006: Autofill server-side heuristics for 2 fields password form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/form_cache.cc ('k') | components/autofill/core/browser/autofill_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_manager.cc

diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc

index 3bfcfd01c4d50562f9f1b14e3b88bccd3bb7ae98..f767e77dd7eb54db3802987a03a1262368b83def 100644

--- a/components/autofill/core/browser/autofill_manager.cc

+++ b/components/autofill/core/browser/autofill_manager.cc

@@ -943,7 +943,10 @@ bool AutofillManager::IsCreditCardUploadEnabled() {

bool AutofillManager::ShouldUploadForm(const FormStructure& form) {

return IsAutofillEnabled() && !driver_->IsOffTheRecord() &&

form.ShouldBeParsed() &&

- form.active_field_count() >= kRequiredFieldsForUpload;

+ (form.active_field_count() >= kRequiredFieldsForUpload ||

+ (form.all_fields_are_passwords() &&

+ form.active_field_count() >=

+ kRequiredFieldsForFormsWithOnlyPasswordFields));

}

void AutofillManager::ImportFormData(const FormStructure& submitted_form) {