Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: components/autofill/core/common/autofill_constants.h

Issue 1670763006: Autofill server-side heuristics for 2 fields password form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More tests Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/common/autofill_constants.h
diff --git a/components/autofill/core/common/autofill_constants.h b/components/autofill/core/common/autofill_constants.h
index 9c89bddc809dad5c1430d99275022929c320879b..b725f694d300d72e3fd8ea4d2e3e32ad9fcaa4ec 100644
--- a/components/autofill/core/common/autofill_constants.h
+++ b/components/autofill/core/common/autofill_constants.h
@@ -25,6 +25,10 @@ const size_t kRequiredFieldsForPredictionRoutines = 3;
// servers.
const size_t kRequiredFieldsForUpload = 3;
+// The minimum number of fields in a form that contains only passwords fields to
Ilya Sherman 2016/02/09 22:33:39 nit: s/passwords/password
dvadym 2016/02/10 11:58:28 Done.
+// upload the form to and request predictions from the Autofill servers.
+const size_t kRequiredFieldsAllPasswordsForUploadAndPrediction = 2;
Ilya Sherman 2016/02/09 22:33:39 nit: I think something like kRequiredFieldsForForm
dvadym 2016/02/10 11:58:28 Thanks kRequiredFieldsForFormsWithOnlyPasswordFiel
+
// Options bitmask values for AutofillHostMsg_ShowPasswordSuggestions IPC
enum ShowPasswordSuggestionsOptions {
SHOW_ALL = 1 << 0 /* show all credentials, not just ones matching username */,

Powered by Google App Engine
This is Rietveld 408576698