Autofill server-side heuristics for 2 fields password form

components/autofill/content/renderer/form_cache.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/form_cache.h"
 
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/stl_util.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 47 matching lines @@
 }
 
 // Determines whether the form is interesting enough to send to the browser
 // for further operations.
 bool IsFormInteresting(const FormData& form, size_t num_editable_elements) {
   if (form.fields.empty())
     return false;
 
   // If the form has at least one field with an autocomplete attribute, it is a
   // candidate for autofill.
+  bool all_fields_are_passwords = true;
   for (const FormFieldData& field : form.fields) {
     if (!field.autocomplete_attribute.empty())
       return true;
+    if (field.form_control_type != "password")

[Ilya Sherman, 2016/02/09 22:33:39]

Not related to this change, but it would be nice to someday change this field
type from using strings to using an enum...

[dvadym, 2016/02/10 11:58:28]

Yeah, I also was wondering why string used for this field. I've checked most of
work of transition from string to enum could by automatized with scripts. I'll
do this as 20% in a week or so.

+      all_fields_are_passwords = false;
   }
 
   // If there are no autocomplete attributes, the form needs to have at least
   // the required number of editable fields for the prediction routines to be a
   // candidate for autofill.
-  return num_editable_elements >= kRequiredFieldsForPredictionRoutines;
+  return num_editable_elements >= kRequiredFieldsForPredictionRoutines ||
+         (all_fields_are_passwords &&
+          num_editable_elements >=
+              kRequiredFieldsAllPasswordsForUploadAndPrediction);
 }
 
 }  // namespace
 
 FormCache::FormCache(const WebFrame& frame) : frame_(frame) {
 }
 
 FormCache::~FormCache() {
 }
 
@@ skipping 262 matching lines @@
       const WebInputElement* input_element = toWebInputElement(&element);
       if (form_util::IsCheckableElement(input_element)) {
         initial_checked_state_.insert(
             std::make_pair(*input_element, input_element->isChecked()));
       }
     }
   }
 }
 
 }  // namespace autofill