Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1670753003: multibuffer field trial (Closed)

Created:
4 years, 10 months ago by hubbe
Modified:
4 years, 10 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

multibuffer field trial BUG=514719 Committed: https://crrev.com/2703d09eeaed647bec80a34af141bd8831378c7c Cr-Commit-Position: refs/heads/master@{#374773}

Patch Set 1 #

Total comments: 2

Patch Set 2 : use feature api #

Patch Set 3 : formatted #

Total comments: 2

Patch Set 4 : added newline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -7 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M media/base/media_switches.h View 1 2 3 2 chunks +9 lines, -2 lines 0 comments Download
M media/base/media_switches.cc View 1 2 1 chunk +7 lines, -2 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
hubbe
4 years, 10 months ago (2016-02-05 00:53:34 UTC) #2
DaleCurtis
https://codereview.chromium.org/1670753003/diff/1/media/blink/webmediaplayer_impl.cc File media/blink/webmediaplayer_impl.cc (right): https://codereview.chromium.org/1670753003/diff/1/media/blink/webmediaplayer_impl.cc#newcode294 media/blink/webmediaplayer_impl.cc:294: // TODO(hubbe): This experiment is temporary and should be ...
4 years, 10 months ago (2016-02-05 01:05:18 UTC) #3
hubbe
https://codereview.chromium.org/1670753003/diff/1/media/blink/webmediaplayer_impl.cc File media/blink/webmediaplayer_impl.cc (right): https://codereview.chromium.org/1670753003/diff/1/media/blink/webmediaplayer_impl.cc#newcode294 media/blink/webmediaplayer_impl.cc:294: // TODO(hubbe): This experiment is temporary and should be ...
4 years, 10 months ago (2016-02-09 22:01:59 UTC) #4
DaleCurtis
lgtm, +asvitkine to double check feature usage.
4 years, 10 months ago (2016-02-09 22:48:34 UTC) #6
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/1670753003/diff/40001/media/base/media_switches.h File media/base/media_switches.h (right): https://codereview.chromium.org/1670753003/diff/40001/media/base/media_switches.h#newcode68 media/base/media_switches.h:68: namespace media { Nit: Add an empty line ...
4 years, 10 months ago (2016-02-10 17:29:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1670753003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1670753003/60001
4 years, 10 months ago (2016-02-10 18:07:31 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/21356)
4 years, 10 months ago (2016-02-10 21:23:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1670753003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1670753003/60001
4 years, 10 months ago (2016-02-10 21:56:03 UTC) #14
hubbe
https://codereview.chromium.org/1670753003/diff/40001/media/base/media_switches.h File media/base/media_switches.h (right): https://codereview.chromium.org/1670753003/diff/40001/media/base/media_switches.h#newcode68 media/base/media_switches.h:68: namespace media { On 2016/02/10 17:29:50, Alexei Svitkine wrote: ...
4 years, 10 months ago (2016-02-10 22:10:18 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-02-10 23:17:24 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:32:19 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2703d09eeaed647bec80a34af141bd8831378c7c
Cr-Commit-Position: refs/heads/master@{#374773}

Powered by Google App Engine
This is Rietveld 408576698