chrome/common/extensions/api/experimental_system_info_storage.idl - Issue 16707002: [SystemInfo API] Rewrite storage info provider using storage monitor impl.

Unified Diff: chrome/common/extensions/api/experimental_system_info_storage.idl

Issue 16707002: [SystemInfo API] Rewrite storage info provider using storage monitor impl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove storage_info_provider_linux_unittest.cc in chrome_tests_unit.gypi Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/system_info_storage/test_storage_info_provider.h ('K') | « chrome/chrome_tests_unit.gypi ('k') | chrome/test/data/extensions/api_test/systeminfo/storage/test_storage_api.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/experimental_system_info_storage.idl

diff --git a/chrome/common/extensions/api/experimental_system_info_storage.idl b/chrome/common/extensions/api/experimental_system_info_storage.idl

index d6d5002dfcc6a38f0c91ee6b271da30cf570c318..c3dce20bd008cc73767b82145154af67dfad88a5 100644

--- a/chrome/common/extensions/api/experimental_system_info_storage.idl

+++ b/chrome/common/extensions/api/experimental_system_info_storage.idl

@@ -14,8 +14,10 @@ namespace experimental.systemInfo.storage {

};

dictionary StorageUnitInfo {

- // The unique id of the storage unit.

+ // The unique storage id. It is persistent between storage attachments.

DOMString id;

+ // The mount path of the storage unit.

+ DOMString location;

Greg Billock 2013/06/18 18:24:52 Does this get exposed to apps? That seems like a p

Haojian Wu 2013/06/21 05:49:04 Currently I'm not sure. The systemInfo.storage api

Hongbo Min 2013/06/22 09:52:28 The reason why it should be exposed is, it could t

Greg Billock 2013/06/24 16:55:38 That's sensible. I think we should work to make th

Hongbo Min 2013/06/25 01:55:07 Agree!

Haojian Wu 2013/06/26 03:22:39 Does this means changing the IDL name "location" t

Greg Billock 2013/06/26 17:32:48 Yes. That sounds right. I saw a note from Steve th

Haojian Wu 2013/06/27 09:17:59 Done.

// The media type of the storage unit.

StorageUnitType type;

// The total amount of the storage space, in bytes.

Greg Billock 2013/06/18 18:24:52 Document what the default values are in case we ca

Haojian Wu 2013/06/21 05:49:04 Done.