Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: chrome/browser/ui/android/snackbars/auto_signin_prompt_controller.cc

Issue 1670673004: Revert "[Smart Lock, UI] First run expience for Auto sign-in prompt." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/snackbars/auto_signin_prompt_controller.cc
diff --git a/chrome/browser/ui/android/snackbars/auto_signin_prompt_controller.cc b/chrome/browser/ui/android/snackbars/auto_signin_prompt_controller.cc
index 2edc8a5385b393b0815516f564ada0fc92f0c493..2ddec59a9052d176ac397b5d27027952dc7452bc 100644
--- a/chrome/browser/ui/android/snackbars/auto_signin_prompt_controller.cc
+++ b/chrome/browser/ui/android/snackbars/auto_signin_prompt_controller.cc
@@ -7,7 +7,6 @@
#include "base/android/jni_android.h"
#include "base/android/jni_string.h"
#include "chrome/browser/android/tab_android.h"
-#include "chrome/browser/password_manager/auto_signin_first_run_infobar_delegate.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/grit/generated_resources.h"
#include "components/password_manager/core/browser/password_bubble_experiment.h"
@@ -17,22 +16,15 @@
void ShowAutoSigninPrompt(content::WebContents* web_contents,
const base::string16& username) {
- Profile* profile =
- Profile::FromBrowserContext(web_contents->GetBrowserContext());
base::string16 message = l10n_util::GetStringFUTF16(
IDS_MANAGE_PASSWORDS_AUTO_SIGNIN_TITLE, username);
- if (password_bubble_experiment::ShouldShowAutoSignInPromptFirstRunExperience(
- profile->GetPrefs())) {
- AutoSigninFirstRunInfoBarDelegate::Create(web_contents, message);
- } else {
JNIEnv* env = base::android::AttachCurrentThread();
Ted C 2016/02/09 17:22:22 decrease the intent of this section now?
melandory 2016/02/10 00:11:57 Done.
TabAndroid* tab = TabAndroid::FromWebContents(web_contents);
ScopedJavaLocalRef<jstring> java_message =
base::android::ConvertUTF16ToJavaString(env, message);
Java_AutoSigninSnackbarController_showSnackbar(
env, tab->GetJavaObject().obj(), java_message.obj());
- }
}
bool RegisterAutoSigninSnackbarController(JNIEnv* env) {

Powered by Google App Engine
This is Rietveld 408576698