chrome/common/extensions/api/web_navigation.json - Issue 1670673003: Refactor the implementation of the webNavigation extension API.

Unified Diff: chrome/common/extensions/api/web_navigation.json

Issue 1670673003: Refactor the implementation of the webNavigation extension API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Bug-532666-NavigationHandleAPI

Patch Set: Reverting the workaround from https://codereview.chromium.org/1656613002. Remove tests from exclusi… Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/web_navigation/web_navigation_api.cc ('K') | « chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc ('k') | chrome/test/data/extensions/api_test/executescript/http204/background.js » ('j') | extensions/browser/extension_api_frame_id_map.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/web_navigation.json

diff --git a/chrome/common/extensions/api/web_navigation.json b/chrome/common/extensions/api/web_navigation.json

index fa32a6d48f76714a81ab9d0ccd06216bef5fcbec..608345b5699b31d9fb0c45d4f82f78b8b2134b4f 100644

--- a/chrome/common/extensions/api/web_navigation.json

+++ b/chrome/common/extensions/api/web_navigation.json

@@ -137,7 +137,7 @@

"properties": {

"tabId": {"type": "integer", "description": "The ID of the tab in which the navigation is about to occur."},

"url": {"type": "string"},

- "processId": {"type": "integer", "description": "The ID of the process that runs the renderer for this frame."},

+ "processId": {"type": "integer", "description": "The value of -1, since the process which will render the resulting document is not known until onCommit."},

Devlin 2016/02/09 17:35:40 I'd phrase this to include "deprecated" so it's cl

nasko 2016/02/09 17:53:54 Done.

"frameId": {"type": "integer", "description": "0 indicates the navigation happens in the tab content window; a positive value indicates navigation in a subframe. Frame IDs are unique for a given tab and process."},

"parentFrameId": {"type": "integer", "description": "ID of frame that wraps the frame. Set to -1 of no parent frame exists."},

"timeStamp": {"type": "number", "description": "The time when the browser was about to start the navigation, in milliseconds since the epoch."}

@@ -244,7 +244,7 @@

"properties": {

"tabId": {"type": "integer", "description": "The ID of the tab in which the navigation occurs."},

"url": {"type": "string"},

- "processId": {"type": "integer", "description": "The ID of the process that runs the renderer for this frame."},

+ "processId": {"type": "integer", "description": "The value of -1."},

Devlin 2016/02/09 17:35:40 ditto. We also don't object to copy-pasting in do

nasko 2016/02/09 17:53:54 Done.

"frameId": {"type": "integer", "description": "0 indicates the navigation happens in the tab content window; a positive value indicates navigation in a subframe. Frame IDs are unique within a tab."},

"error": {"type": "string", "description": "The error description."},

"timeStamp": {"type": "number", "description": "The time when the error occurred, in milliseconds since the epoch."}