extensions/browser/extension_api_frame_id_map.h - Issue 1670673003: Refactor the implementation of the webNavigation extension API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_api_frame_id_map.h

Issue 1670673003: Refactor the implementation of the webNavigation extension API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Bug-532666-NavigationHandleAPI

Patch Set: Remove UI thread DCHECKs. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/webnavigation/userAction/test_userAction.js ('k') | extensions/browser/extension_api_frame_id_map.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/extension_api_frame_id_map.h

diff --git a/extensions/browser/extension_api_frame_id_map.h b/extensions/browser/extension_api_frame_id_map.h

index c3af8b3da24a9db946b1df8cd90af3200d683525..f1fffe4dca8c048c6d85a91f343a7b63e8ab8e38 100644

--- a/extensions/browser/extension_api_frame_id_map.h

+++ b/extensions/browser/extension_api_frame_id_map.h

@@ -14,6 +14,7 @@

#include "base/synchronization/lock.h"

namespace content {

+class NavigationHandle;

class RenderFrameHost;

class WebContents;

} // namespace content

@@ -53,9 +54,15 @@ class ExtensionApiFrameIdMap {

// Get the extension API frame ID for |rfh|.

static int GetFrameId(content::RenderFrameHost* rfh);

+ // Get the extension API frame ID for |navigation_handle|.

+ static int GetFrameId(content::NavigationHandle* navigation_handle);

// Get the extension API frame ID for the parent of |rfh|.

static int GetParentFrameId(content::RenderFrameHost* rfh);

+ // Get the extension API frame ID for the parent of |navigation_handle|.

+ static int GetParentFrameId(content::NavigationHandle* navigation_handle);

// Find the current RenderFrameHost for a given WebContents and extension

// frame ID.

// Returns nullptr if not found.