chrome/test/data/extensions/api_test/webnavigation/crossProcessHistory/test_crossProcessHistory.js - Issue 1670673003: Refactor the implementation of the webNavigation extension API.

Unified Diff: chrome/test/data/extensions/api_test/webnavigation/crossProcessHistory/test_crossProcessHistory.js

Issue 1670673003: Refactor the implementation of the webNavigation extension API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Bug-532666-NavigationHandleAPI

Patch Set: Remove UI thread DCHECKs. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/webnavigation/crossProcessHistory/framework.js ('k') | chrome/test/data/extensions/api_test/webnavigation/crossProcessIframe/framework.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/webnavigation/crossProcessHistory/test_crossProcessHistory.js

diff --git a/chrome/test/data/extensions/api_test/webnavigation/crossProcessHistory/test_crossProcessHistory.js b/chrome/test/data/extensions/api_test/webnavigation/crossProcessHistory/test_crossProcessHistory.js

index 2bf9d1871fb12a6569565bd2f17dc3f32846262d..a045ea4b9d4a67ad82793a6814f440b5ba07d098 100644

--- a/chrome/test/data/extensions/api_test/webnavigation/crossProcessHistory/test_crossProcessHistory.js

+++ b/chrome/test/data/extensions/api_test/webnavigation/crossProcessHistory/test_crossProcessHistory.js

@@ -12,6 +12,7 @@ onload = function() {

return url.replace(/PORT/g, config.testServer.port);

};

URL_TEST = fixPort(URL_TEST);

+ let areExtensionsIsolated = config.isolateExtensions;

chrome.test.runTests([

// Navigates to a different site, but then modifies the history using

@@ -22,7 +23,7 @@ onload = function() {

event: "onBeforeNavigate",

details: { frameId: 0,

parentFrameId: -1,

- processId: 0,

+ processId: -1,

tabId: 0,

timeStamp: 0,

url: getURL('e.html') }},

@@ -62,7 +63,7 @@ onload = function() {

event: "onBeforeNavigate",

details: { frameId: 0,

parentFrameId: -1,

- processId: 1,

+ processId: -1,

tabId: 0,

timeStamp: 0,

url: URL_TEST + "2" }},

@@ -107,7 +108,7 @@ onload = function() {

event: "onBeforeNavigate",

details: { frameId: 0,

parentFrameId: -1,

- processId: 0,

+ processId: -1,

tabId: 0,

timeStamp: 0,

url: getURL('h.html') }},

@@ -147,14 +148,14 @@ onload = function() {

event: "onBeforeNavigate",

details: { frameId: 1,

parentFrameId: 0,

- processId: 0,

+ processId: -1,

tabId: 0,

timeStamp: 0,

url: URL_TEST + "5" }},

{ label: "b-onCommitted",

event: "onCommitted",

details: { frameId: 1,

- processId: 0,

+ processId: (areExtensionsIsolated ? 1 : 0),

tabId: 0,

timeStamp: 0,

transitionQualifiers: [],

@@ -163,14 +164,14 @@ onload = function() {

{ label: "b-onDOMContentLoaded",

event: "onDOMContentLoaded",

details: { frameId: 1,

- processId: 0,

+ processId: (areExtensionsIsolated ? 1 : 0),

tabId: 0,

timeStamp: 0,

url: URL_TEST + "5" }},

{ label: "b-onCompleted",

event: "onCompleted",

details: { frameId: 1,

- processId: 0,

+ processId: (areExtensionsIsolated ? 1 : 0),

tabId: 0,

timeStamp: 0,

url: URL_TEST + "5" }}],

@@ -192,7 +193,7 @@ onload = function() {

event: "onBeforeNavigate",

details: { frameId: 0,

parentFrameId: -1,

- processId: 0,

+ processId: -1,

tabId: 0,

timeStamp: 0,

url: getURL('i.html') }},

@@ -232,7 +233,7 @@ onload = function() {

event: "onBeforeNavigate",

details: { frameId: 0,

parentFrameId: -1,

- processId: 1,

+ processId: -1,

tabId: 0,

timeStamp: 0,

url: URL_TEST + "6" }},