chrome/test/data/extensions/api_test/webnavigation/crossProcessFragment/test_crossProcessFragment.js - Issue 1670673003: Refactor the implementation of the webNavigation extension API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/webnavigation/crossProcessFragment/test_crossProcessFragment.js

Issue 1670673003: Refactor the implementation of the webNavigation extension API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Bug-532666-NavigationHandleAPI

Patch Set: Remove UI thread DCHECKs. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/webnavigation/crossProcessFragment/framework.js ('k') | chrome/test/data/extensions/api_test/webnavigation/crossProcessHistory/framework.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/webnavigation/crossProcessFragment/test_crossProcessFragment.js

diff --git a/chrome/test/data/extensions/api_test/webnavigation/crossProcessFragment/test_crossProcessFragment.js b/chrome/test/data/extensions/api_test/webnavigation/crossProcessFragment/test_crossProcessFragment.js

index 8097753af2ac58869ebcb95fb44e6af1888f06c6..0fc0dd3237394348774832df888a7d41415310ae 100644

--- a/chrome/test/data/extensions/api_test/webnavigation/crossProcessFragment/test_crossProcessFragment.js

+++ b/chrome/test/data/extensions/api_test/webnavigation/crossProcessFragment/test_crossProcessFragment.js

@@ -12,6 +12,7 @@ onload = function() {

return url.replace(/PORT/g, config.testServer.port);

};

URL_TEST = fixPort(URL_TEST);

+ let areExtensionsIsolated = config.isolateExtensions;

chrome.test.runTests([

// Navigates to a different site, but then modifies the reference

@@ -22,7 +23,7 @@ onload = function() {

event: "onBeforeNavigate",

details: { frameId: 0,

parentFrameId: -1,

- processId: 0,

+ processId: -1,

tabId: 0,

timeStamp: 0,

url: getURL('f.html') }},

@@ -62,7 +63,7 @@ onload = function() {

event: "onBeforeNavigate",

details: { frameId: 0,

parentFrameId: -1,

- processId: 1,

+ processId: -1,

tabId: 0,

timeStamp: 0,

url: URL_TEST + "3" }},

@@ -107,7 +108,7 @@ onload = function() {

event: "onBeforeNavigate",

details: { frameId: 0,

parentFrameId: -1,

- processId: 0,

+ processId: -1,

tabId: 0,

timeStamp: 0,

url: getURL('g.html') }},

@@ -147,14 +148,14 @@ onload = function() {

event: "onBeforeNavigate",

details: { frameId: 1,

parentFrameId: 0,

- processId: 0,

+ processId: -1,

tabId: 0,

timeStamp: 0,

url: URL_TEST + "4" }},

{ label: "b-onCommitted",

event: "onCommitted",

details: { frameId: 1,

- processId: 0,

+ processId: (areExtensionsIsolated ? 1 : 0),

tabId: 0,

timeStamp: 0,

transitionQualifiers: [],

@@ -163,14 +164,14 @@ onload = function() {

{ label: "b-onDOMContentLoaded",

event: "onDOMContentLoaded",

details: { frameId: 1,

- processId: 0,

+ processId: (areExtensionsIsolated ? 1 : 0),

tabId: 0,

timeStamp: 0,

url: URL_TEST + "4" }},

{ label: "b-onCompleted",

event: "onCompleted",

details: { frameId: 1,

- processId: 0,

+ processId: (areExtensionsIsolated ? 1 : 0),

tabId: 0,

timeStamp: 0,

url: URL_TEST + "4" }}],