chrome/test/data/extensions/api_test/webnavigation/crossProcess/test_crossProcess.js - Issue 1670673003: Refactor the implementation of the webNavigation extension API.

Unified Diff: chrome/test/data/extensions/api_test/webnavigation/crossProcess/test_crossProcess.js

Issue 1670673003: Refactor the implementation of the webNavigation extension API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Bug-532666-NavigationHandleAPI

Patch Set: Remove UI thread DCHECKs. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/webnavigation/crossProcess/framework.js ('k') | chrome/test/data/extensions/api_test/webnavigation/crossProcessAbort/framework.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/webnavigation/crossProcess/test_crossProcess.js

diff --git a/chrome/test/data/extensions/api_test/webnavigation/crossProcess/test_crossProcess.js b/chrome/test/data/extensions/api_test/webnavigation/crossProcess/test_crossProcess.js

index 5479b3c0f3f9949c84538f2f0fd81c81fdb223a0..0414c827d8603970f91a5b7f0919bc0b8fa77119 100644

--- a/chrome/test/data/extensions/api_test/webnavigation/crossProcess/test_crossProcess.js

+++ b/chrome/test/data/extensions/api_test/webnavigation/crossProcess/test_crossProcess.js

@@ -28,7 +28,7 @@ onload = function() {

event: "onBeforeNavigate",

details: { frameId: 0,

parentFrameId: -1,

- processId: 0,

+ processId: -1,

tabId: 0,

timeStamp: 0,

url: getURL('a.html') }},

@@ -59,7 +59,7 @@ onload = function() {

event: "onBeforeNavigate",

details: { frameId: 0,

parentFrameId: -1,

- processId: 1,

+ processId: -1,

tabId: 0,

timeStamp: 0,

url: URL_REGULAR }},

@@ -100,7 +100,7 @@ onload = function() {

event: "onBeforeNavigate",

details: { frameId: 0,

parentFrameId: -1,

- processId: 0,

+ processId: -1,

tabId: 0,

timeStamp: 0,

url: getURL('c.html') }},

@@ -127,57 +127,38 @@ onload = function() {

tabId: 0,

timeStamp: 0,

url: getURL('c.html') }},

- { label: "b-onBeforeNavigate",

- event: "onBeforeNavigate",

- details: { frameId: 0,

- parentFrameId: -1,

- processId: 1,

- tabId: 0,

- timeStamp: 0,

- url: URL_REDIRECT }},

- { label: "b-onErrorOccurred",

- event: "onErrorOccurred",

- details: { error: "net::ERR_ABORTED",

- frameId: 0,

- processId: 1,

- tabId: 0,

- timeStamp: 0,

- url: URL_REDIRECT }},

{ label: "c-onBeforeNavigate",

event: "onBeforeNavigate",

details: { frameId: 0,

parentFrameId: -1,

- processId: 2,

+ processId: -1,

tabId: 0,

timeStamp: 0,

- url: URL_REGULAR }},

+ url: URL_REDIRECT }},

{ label: "c-onCommitted",

event: "onCommitted",

details: { frameId: 0,

- processId: 2,

+ processId: 1,

tabId: 0,

timeStamp: 0,

- transitionQualifiers: [],

+ transitionQualifiers: ["server_redirect"],

transitionType: "link",

url: URL_REGULAR }},

{ label: "c-onDOMContentLoaded",

event: "onDOMContentLoaded",

details: { frameId: 0,

- processId: 2,

+ processId: 1,

tabId: 0,

timeStamp: 0,

url: URL_REGULAR }},

{ label: "c-onCompleted",

event: "onCompleted",

details: { frameId: 0,

- processId: 2,

+ processId: 1,

tabId: 0,

timeStamp: 0,

url: URL_REGULAR }}],

- [ navigationOrder("a-"),

- navigationOrder("c-"),

- [ "a-onCompleted", "b-onBeforeNavigate", "b-onErrorOccurred",

- "c-onBeforeNavigate"] ]);

+ [ navigationOrder("a-"), navigationOrder("c-"), ]);

chrome.tabs.update(

tabId,

@@ -197,7 +178,7 @@ onload = function() {

event: "onBeforeNavigate",

details: { frameId: 0,

parentFrameId: -1,

- processId: 0,

+ processId: -1,

tabId: 0,

timeStamp: 0,

url: getURL('d.html') }},

@@ -228,7 +209,7 @@ onload = function() {

event: "onBeforeNavigate",

details: { frameId: 0,

parentFrameId: -1,

- processId: 1,

+ processId: -1,

tabId: 0,

timeStamp: 0,

url: URL_TEST + "1" }},

@@ -259,7 +240,7 @@ onload = function() {

event: "onBeforeNavigate",

details: { frameId: 0,

parentFrameId: -1,

- processId: 0,

+ processId: -1,

tabId: 0,

timeStamp: 0,

url: getURL('empty.html') }},

@@ -311,7 +292,7 @@ onload = function() {

event: "onBeforeNavigate",

details: { frameId: 0,

parentFrameId: -1,

- processId: 0,

+ processId: -1,

tabId: 0,

timeStamp: 0,

url: getURL('d.html') }},

@@ -342,7 +323,7 @@ onload = function() {

event: "onBeforeNavigate",

details: { frameId: 0,

parentFrameId: -1,

- processId: 1,

+ processId: -1,

tabId: 0,

timeStamp: 0,

url: URL_TEST + "2" }},

@@ -350,7 +331,7 @@ onload = function() {

event: "onErrorOccurred",

details: { error: "net::ERR_ABORTED",

frameId: 0,

- processId: 1,

+ processId: -1,

tabId: 0,

timeStamp: 0,

url: URL_TEST + "2" }},

@@ -358,7 +339,7 @@ onload = function() {

event: "onBeforeNavigate",

details: { frameId: 0,

parentFrameId: -1,

- processId: 0,

+ processId: -1,

tabId: 0,

timeStamp: 0,

url: getURL('empty.html') }},