chrome/common/extensions/api/web_navigation.json - Issue 1670673003: Refactor the implementation of the webNavigation extension API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/web_navigation.json

Issue 1670673003: Refactor the implementation of the webNavigation extension API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Bug-532666-NavigationHandleAPI

Patch Set: Remove UI thread DCHECKs. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc ('k') | chrome/test/data/extensions/api_test/executescript/http204/background.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/web_navigation.json

diff --git a/chrome/common/extensions/api/web_navigation.json b/chrome/common/extensions/api/web_navigation.json

index fa32a6d48f76714a81ab9d0ccd06216bef5fcbec..6d18dd5810c782e8d55fff2a07b404512af67f3e 100644

--- a/chrome/common/extensions/api/web_navigation.json

+++ b/chrome/common/extensions/api/web_navigation.json

@@ -137,7 +137,11 @@

"properties": {

"tabId": {"type": "integer", "description": "The ID of the tab in which the navigation is about to occur."},

"url": {"type": "string"},

- "processId": {"type": "integer", "description": "The ID of the process that runs the renderer for this frame."},

+ "processId": {

+ "type": "integer",

+ "description": "The value of -1.",

+ "deprecated": "The processId is no longer set for this event, since the process which will render the resulting document is not known until onCommit."

+ },

"frameId": {"type": "integer", "description": "0 indicates the navigation happens in the tab content window; a positive value indicates navigation in a subframe. Frame IDs are unique for a given tab and process."},

"parentFrameId": {"type": "integer", "description": "ID of frame that wraps the frame. Set to -1 of no parent frame exists."},

"timeStamp": {"type": "number", "description": "The time when the browser was about to start the navigation, in milliseconds since the epoch."}

@@ -244,7 +248,11 @@

"properties": {

"tabId": {"type": "integer", "description": "The ID of the tab in which the navigation occurs."},

"url": {"type": "string"},

- "processId": {"type": "integer", "description": "The ID of the process that runs the renderer for this frame."},

+ "processId": {

+ "type": "integer",

+ "description": "The value of -1.",

+ "deprecated": "The processId is no longer set for this event."

+ },

"frameId": {"type": "integer", "description": "0 indicates the navigation happens in the tab content window; a positive value indicates navigation in a subframe. Frame IDs are unique within a tab."},

"error": {"type": "string", "description": "The error description."},

"timeStamp": {"type": "number", "description": "The time when the error occurred, in milliseconds since the epoch."}