Refactor the implementation of the webNavigation extension API.

chrome/browser/extensions/api/web_navigation/frame_navigation_state.h

Index: chrome/browser/extensions/api/web_navigation/frame_navigation_state.h
diff --git a/chrome/browser/extensions/api/web_navigation/frame_navigation_state.h b/chrome/browser/extensions/api/web_navigation/frame_navigation_state.h
index 4363960795e890a6c1b12d9ec960a04f7810877f..e8823923587d6a6ae4bbe13f89cf14286bdeb1c2 100644
--- a/chrome/browser/extensions/api/web_navigation/frame_navigation_state.h
+++ b/chrome/browser/extensions/api/web_navigation/frame_navigation_state.h
@@ -40,10 +40,11 @@ class FrameNavigationState {
   bool CanSendEvents(content::RenderFrameHost* frame_host) const;
 
   // Starts to track a navigation in |frame_host| to |url|.
-  void StartTrackingNavigation(content::RenderFrameHost* frame_host,
-                               const GURL& url,
-                               bool is_error_page,
-                               bool is_iframe_srcdoc);
+  void StartTrackingDocumentLoad(content::RenderFrameHost* frame_host,
+                                 const GURL& url,
+                                 bool is_same_page,
+                                 bool is_error_page,
+                                 bool is_iframe_srcdoc);
 
   // Adds the |frame_host| to the set of RenderFrameHosts associated with the
   // WebContents this object is tracking. This method and FrameHostDeleted
@@ -86,19 +87,6 @@ class FrameNavigationState {
   // True if |frame_host| has finished parsing.
   bool GetParsingFinished(content::RenderFrameHost* frame_host) const;
 
-  // Marks |frame_host| as having committed its navigation, i.e. the onCommitted
-  // event was fired for this frame.
-  void SetNavigationCommitted(content::RenderFrameHost* frame_host);
-
-  // True if |frame_host| has committed its navigation.
-  bool GetNavigationCommitted(content::RenderFrameHost* frame_host) const;
-
-  // Marks |frame_host| as redirected by the server.
-  void SetIsServerRedirected(content::RenderFrameHost* frame_host);
-
-  // True if |frame_host| was redirected by the server.
-  bool GetIsServerRedirected(content::RenderFrameHost* frame_host) const;
-
 #ifdef UNIT_TEST
   static void set_allow_extension_scheme(bool allow_extension_scheme) {
     allow_extension_scheme_ = allow_extension_scheme;
@@ -111,9 +99,7 @@ class FrameNavigationState {
 
     bool error_occurred;  // True if an error has occurred in this frame.
     bool is_iframe_srcdoc;  // True if the frame is displaying its srcdoc.
-    bool is_navigating;  // True if there is a navigation going on.
-    bool is_committed;  // True if the navigation is already committed.
-    bool is_server_redirected;  // True if a server redirect happened.
+    bool is_loading;        // True if there is a navigation going on.

[Devlin, 2016/02/05 18:30:28]

this comment is weird, given that this is set to true from
DidFinishNavigation().  I think we should change it.  (See also other comment in
DidFinishNavigation)

[nasko, 2016/02/05 23:41:22]

In general, the model we want to move to is have clear separation between the
different stages of a "navigation". The navigation stage - the resource request
until commit time, and the document loading stage - once we've committed and
started parsing the document, until all subresource/subframe loads are complete.

I missed updating the comment.

     bool is_parsing;  // True if the frame is still parsing.
     GURL url;  // URL of this frame.
   };