Refactor the implementation of the webNavigation extension API.

chrome/test/data/extensions/api_test/webnavigation/crossProcessFragment/test_crossProcessFragment.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 onload = function() {
   var getURL = chrome.extension.getURL;
   var URL_TEST = "http://127.0.0.1:PORT/test";
   chrome.tabs.create({"url": "about:blank"}, function(tab) {
     var tabId = tab.id;
     chrome.test.getConfig(function(config) {
       var fixPort = function(url) {
         return url.replace(/PORT/g, config.testServer.port);
       };
       URL_TEST = fixPort(URL_TEST);
+      let areExtensionsIsolated = config.isolateExtensions;

[Devlin, 2016/02/05 18:30:28]

I could have sworn let only worked with "use strict";.  Maybe I'm
misremembering?

[nasko, 2016/02/05 23:41:22]

Tends to work and I copied it from other places we use this statement. I could
switch it to use var, it won't change much. I usually like to keep things the
same when I copy/paste, so it can be easily grepped for in the future.

 
       chrome.test.runTests([
         // Navigates to a different site, but then modifies the reference
         // framgent.
         function crossProcessFragment() {
           expect([
             { label: "a-onBeforeNavigate",
               event: "onBeforeNavigate",
               details: { frameId: 0,
                          parentFrameId: -1,
-                         processId: 0,
+                         processId: -1,
                          tabId: 0,
                          timeStamp: 0,
                          url: getURL('f.html') }},
             { label: "a-onCommitted",
               event: "onCommitted",
               details: { frameId: 0,
                          processId: 0,
                          tabId: 0,
                          timeStamp: 0,
                          transitionQualifiers: [],
@@ skipping 19 matching lines @@
                          processId: 0,
                          tabId: 0,
                          timeStamp: 0,
                          transitionQualifiers: [],
                          transitionType: "link",
                          url: getURL('f.html#foo') }},
             { label: "b-onBeforeNavigate",
               event: "onBeforeNavigate",
               details: { frameId: 0,
                          parentFrameId: -1,
-                         processId: 1,
+                         processId: -1,
                          tabId: 0,
                          timeStamp: 0,
                          url: URL_TEST + "3" }},
             { label: "b-onCommitted",
               event: "onCommitted",
               details: { frameId: 0,
                          processId: 1,
                          tabId: 0,
                          timeStamp: 0,
                          transitionQualifiers: [],
@@ skipping 24 matching lines @@
         },
 
         // A page with an iframe that changes its reference fragment before
         // the iframe committed.
         function crossProcessFragmentIFrame() {
           expect([
             { label: "a-onBeforeNavigate",
               event: "onBeforeNavigate",
               details: { frameId: 0,
                          parentFrameId: -1,
-                         processId: 0,
+                         processId: -1,
                          tabId: 0,
                          timeStamp: 0,
                          url: getURL('g.html') }},
             { label: "a-onCommitted",
               event: "onCommitted",
               details: { frameId: 0,
                          processId: 0,
                          tabId: 0,
                          timeStamp: 0,
                          transitionQualifiers: [],
@@ skipping 19 matching lines @@
                          processId: 0,
                          tabId: 0,
                          timeStamp: 0,
                          transitionQualifiers: [],
                          transitionType: "link",
                          url: getURL('g.html#foo') }},
             { label: "b-onBeforeNavigate",
               event: "onBeforeNavigate",
               details: { frameId: 1,
                          parentFrameId: 0,
-                         processId: 0,
+                         processId: -1,
                          tabId: 0,
                          timeStamp: 0,
                          url: URL_TEST + "4" }},
             { label: "b-onCommitted",
               event: "onCommitted",
               details: { frameId: 1,
-                         processId: 0,
+                         processId: (areExtensionsIsolated ? 1 : 0),
                          tabId: 0,
                          timeStamp: 0,
                          transitionQualifiers: [],
                          transitionType: "auto_subframe",
                          url: URL_TEST + "4" }},
             { label: "b-onDOMContentLoaded",
               event: "onDOMContentLoaded",
               details: { frameId: 1,
-                         processId: 0,
+                         processId: (areExtensionsIsolated ? 1 : 0),
                          tabId: 0,
                          timeStamp: 0,
                          url: URL_TEST + "4" }},
             { label: "b-onCompleted",
               event: "onCompleted",
               details: { frameId: 1,
-                         processId: 0,
+                         processId: (areExtensionsIsolated ? 1 : 0),
                          tabId: 0,
                          timeStamp: 0,
                          url: URL_TEST + "4" }}],
             [ navigationOrder("a-"), navigationOrder("b-"),
               [ "a-onCompleted", "b-onBeforeNavigate",
                 "a-onReferenceFragmentUpdated"] ]);
 
           chrome.tabs.update(
               tabId,
               { url: getURL('g.html?' +
                             config.testServer.port) });
         },
 
       ]);
     });
   });
 };