Revert of Views - init less stuff in tabless browsers.

Revert of Views - init less stuff in tabless browsers. (patchset #3 id:40001 of https://codereview.chromium.org/1654223002/ )

Reason for revert:
this is causing a lot of crashes on canary, revert for now and reland later with a fix

Original issue's description:
> Views - init less stuff in tabless browsers.
>
> There's no need to create views that are hidden, register listeners relevant to
> those views, etc. in popup windows.
>
> The one part of BrowserActionsContainer that we do want in popup windows is the ExtensionKeybindingRegistryViews instance. Move this to BrowserView.
>
> BUG=560345
>
> Committed: https://crrev.com/845adff50786ff3c7515d51d04370825ad9e3a8b
> Cr-Commit-Position: refs/heads/master@{#373344}

TBR=pkasting@chromium.org,rdevlin.cronin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
BUG=560345
Committed: https://crrev.com/78a3685d7b92e6ebf4a91b3cbea78b702f567fa3
Cr-Commit-Position: refs/heads/master@{#373609}

[Evan Stade, 2016-02-04 19:35:07]

Created Revert of Views - init less stuff in tabless browsers.

[commit-bot: I haz the power, 2016-02-04 19:36:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1670663002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1670663002/1

[commit-bot: I haz the power, 2016-02-04 19:38:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-04 19:38:21]

Failed to apply patch for chrome/browser/ui/views/frame/browser_view.h:
While running git apply --index -3 -p1;
  error: patch failed: chrome/browser/ui/views/frame/browser_view.h:472
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: chrome/browser/ui/views/frame/browser_view.h: patch does not apply

Patch:       chrome/browser/ui/views/frame/browser_view.h
Index: chrome/browser/ui/views/frame/browser_view.h
diff --git a/chrome/browser/ui/views/frame/browser_view.h
b/chrome/browser/ui/views/frame/browser_view.h
index
a5689df56a509db5d3f827a51ae6f7c1d1c62371..df2055e1e7fe374badcd3403e84282cbc454faf6
100644
--- a/chrome/browser/ui/views/frame/browser_view.h
+++ b/chrome/browser/ui/views/frame/browser_view.h
@@ -16,15 +16,12 @@
 #include "base/timer/timer.h"
 #include "build/build_config.h"
 #include "chrome/browser/devtools/devtools_window.h"
-#include "chrome/browser/extensions/extension_commands_global_registry.h"
-#include "chrome/browser/extensions/extension_keybinding_registry.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/exclusive_access/exclusive_access_context.h"
 #include "chrome/browser/ui/infobar_container_delegate.h"
 #include "chrome/browser/ui/tabs/tab_strip_model_observer.h"
 #include "chrome/browser/ui/views/exclusive_access_bubble_views_context.h"
-#include
"chrome/browser/ui/views/extensions/extension_keybinding_registry_views.h"
 #include "chrome/browser/ui/views/frame/browser_frame.h"
 #include "chrome/browser/ui/views/frame/contents_web_view.h"
 #include "chrome/browser/ui/views/frame/immersive_mode_controller.h"
@@ -68,8 +65,6 @@
 #endif
 
 namespace extensions {
-class ActiveTabPermissionGranter;
-class Command;
 class Extension;
 }
 
@@ -95,8 +90,7 @@
                     public LoadCompleteListener::Delegate,
                     public OmniboxPopupModelObserver,
                     public ExclusiveAccessContext,
-                    public ExclusiveAccessBubbleViewsContext,
-                    public extensions::ExtensionKeybindingRegistry::Delegate {
+                    public ExclusiveAccessBubbleViewsContext {
  public:
   // The browser view's class name.
   static const char kViewClassName[];
@@ -472,10 +466,6 @@
   views::Widget* GetBubbleAssociatedWidget() override;
   gfx::Rect GetTopContainerBoundsInScreen() override;
 
-  // extension::ExtensionKeybindingRegistry::Delegate overrides
-  extensions::ActiveTabPermissionGranter* GetActiveTabPermissionGranter()
-      override;
-
   // Testing interface:
   views::View* GetContentsContainerForTest() { return contents_container_; }
   views::WebView* GetContentsWebViewForTest() { return contents_web_view_; }
@@ -731,9 +721,6 @@
 
   SigninViewController signin_view_controller_;
 
-  // The class that registers for keyboard shortcuts for extension commands.
-  scoped_ptr<ExtensionKeybindingRegistryViews> extension_keybinding_registry_;
-
   mutable base::WeakPtrFactory<BrowserView> activate_modal_dialog_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowserView);

[commit-bot: I haz the power, 2016-02-04 19:39:53]

The CQ bit was unchecked by commit-bot@chromium.org

[Evan Stade, 2016-02-04 19:47:01]

Description was changed from

==========
Revert of Views - init less stuff in tabless browsers. (patchset #3 id:40001 of
https://codereview.chromium.org/1654223002/ )

Reason for revert:
this is causing a lot of crashes on canary, revert for now and reland later with
a fix

Original issue's description:
> Views - init less stuff in tabless browsers.
> 
> There's no need to create views that are hidden, register listeners relevant
to
> those views, etc. in popup windows.
> 
> The one part of BrowserActionsContainer that we do want in popup windows is
the ExtensionKeybindingRegistryViews instance. Move this to BrowserView.
> 
> BUG=560345
> 
> Committed: https://crrev.com/845adff50786ff3c7515d51d04370825ad9e3a8b
> Cr-Commit-Position: refs/heads/master@{#373344}

TBR=pkasting@chromium.org,rdevlin.cronin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=560345
==========

to

==========
Revert of Views - init less stuff in tabless browsers. (patchset #3 id:40001 of
https://codereview.chromium.org/1654223002/ )

Reason for revert:
this is causing a lot of crashes on canary, revert for now and reland later with
a fix

Original issue's description:
> Views - init less stuff in tabless browsers.
> 
> There's no need to create views that are hidden, register listeners relevant
to
> those views, etc. in popup windows.
> 
> The one part of BrowserActionsContainer that we do want in popup windows is
the ExtensionKeybindingRegistryViews instance. Move this to BrowserView.
> 
> BUG=560345
> 
> Committed: https://crrev.com/845adff50786ff3c7515d51d04370825ad9e3a8b
> Cr-Commit-Position: refs/heads/master@{#373344}

TBR=pkasting@chromium.org,rdevlin.cronin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
BUG=560345
==========

[Evan Stade, 2016-02-04 19:47:10]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-02-04 19:48:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1670663002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1670663002/180001

[commit-bot: I haz the power, 2016-02-04 20:38:47]

Description was changed from

==========
Revert of Views - init less stuff in tabless browsers. (patchset #3 id:40001 of
https://codereview.chromium.org/1654223002/ )

Reason for revert:
this is causing a lot of crashes on canary, revert for now and reland later with
a fix

Original issue's description:
> Views - init less stuff in tabless browsers.
> 
> There's no need to create views that are hidden, register listeners relevant
to
> those views, etc. in popup windows.
> 
> The one part of BrowserActionsContainer that we do want in popup windows is
the ExtensionKeybindingRegistryViews instance. Move this to BrowserView.
> 
> BUG=560345
> 
> Committed: https://crrev.com/845adff50786ff3c7515d51d04370825ad9e3a8b
> Cr-Commit-Position: refs/heads/master@{#373344}

TBR=pkasting@chromium.org,rdevlin.cronin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
BUG=560345
==========

to

==========
Revert of Views - init less stuff in tabless browsers. (patchset #3 id:40001 of
https://codereview.chromium.org/1654223002/ )

Reason for revert:
this is causing a lot of crashes on canary, revert for now and reland later with
a fix

Original issue's description:
> Views - init less stuff in tabless browsers.
> 
> There's no need to create views that are hidden, register listeners relevant
to
> those views, etc. in popup windows.
> 
> The one part of BrowserActionsContainer that we do want in popup windows is
the ExtensionKeybindingRegistryViews instance. Move this to BrowserView.
> 
> BUG=560345
> 
> Committed: https://crrev.com/845adff50786ff3c7515d51d04370825ad9e3a8b
> Cr-Commit-Position: refs/heads/master@{#373344}

TBR=pkasting@chromium.org,rdevlin.cronin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
BUG=560345
==========

[commit-bot: I haz the power, 2016-02-04 20:38:48]

Committed patchset #2 (id:180001)

[commit-bot: I haz the power, 2016-02-04 20:40:36]

Description was changed from

==========
Revert of Views - init less stuff in tabless browsers. (patchset #3 id:40001 of
https://codereview.chromium.org/1654223002/ )

Reason for revert:
this is causing a lot of crashes on canary, revert for now and reland later with
a fix

Original issue's description:
> Views - init less stuff in tabless browsers.
> 
> There's no need to create views that are hidden, register listeners relevant
to
> those views, etc. in popup windows.
> 
> The one part of BrowserActionsContainer that we do want in popup windows is
the ExtensionKeybindingRegistryViews instance. Move this to BrowserView.
> 
> BUG=560345
> 
> Committed: https://crrev.com/845adff50786ff3c7515d51d04370825ad9e3a8b
> Cr-Commit-Position: refs/heads/master@{#373344}

TBR=pkasting@chromium.org,rdevlin.cronin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
BUG=560345
==========

to

==========
Revert of Views - init less stuff in tabless browsers. (patchset #3 id:40001 of
https://codereview.chromium.org/1654223002/ )

Reason for revert:
this is causing a lot of crashes on canary, revert for now and reland later with
a fix

Original issue's description:
> Views - init less stuff in tabless browsers.
>
> There's no need to create views that are hidden, register listeners relevant
to
> those views, etc. in popup windows.
>
> The one part of BrowserActionsContainer that we do want in popup windows is
the ExtensionKeybindingRegistryViews instance. Move this to BrowserView.
>
> BUG=560345
>
> Committed: https://crrev.com/845adff50786ff3c7515d51d04370825ad9e3a8b
> Cr-Commit-Position: refs/heads/master@{#373344}

TBR=pkasting@chromium.org,rdevlin.cronin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
BUG=560345

Committed: https://crrev.com/78a3685d7b92e6ebf4a91b3cbea78b702f567fa3
Cr-Commit-Position: refs/heads/master@{#373609}
==========

[commit-bot: I haz the power, 2016-02-04 20:40:36]

Patchset 2 (id:??) landed as
https://crrev.com/78a3685d7b92e6ebf4a91b3cbea78b702f567fa3
Cr-Commit-Position: refs/heads/master@{#373609}

[Peter Kasting, 2016-02-04 21:30:11]

LGTM