Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1670643002: [css-flexbox] Fix main size calculation for overflow:auto (Closed)

Created:
4 years, 10 months ago by cbiesinger
Modified:
4 years, 10 months ago
CC:
chromium-reviews, cbiesinger, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-flexbox] Fix main size calculation for overflow:auto We take child.logicalWidth() as the main size, but that's incorrect - we need the shrink-to-fit width, whereas this code more or less uses the fill-available width. R=leviw@chromium.org BUG=584363 Committed: https://crrev.com/5c171a11db6f7bc54e2acb84a9de6469894f94b9 Cr-Commit-Position: refs/heads/master@{#373592}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-resizes-correctly.html View 3 chunks +11 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-resizes-correctly-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 3 chunks +17 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
cbiesinger
4 years, 10 months ago (2016-02-04 18:35:10 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1670643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1670643002/1
4 years, 10 months ago (2016-02-04 18:35:39 UTC) #3
szager1
lgtm, thanks for continuing to fix this.
4 years, 10 months ago (2016-02-04 18:46:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1670643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1670643002/1
4 years, 10 months ago (2016-02-04 18:49:35 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-04 19:48:37 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 19:49:48 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c171a11db6f7bc54e2acb84a9de6469894f94b9
Cr-Commit-Position: refs/heads/master@{#373592}

Powered by Google App Engine
This is Rietveld 408576698