Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 167063002: Debug-mode check added: optimized keyed store of a smi on x64 is done to a entry containing a smi. (Closed)

Created:
6 years, 10 months ago by Igor Sheludko
Modified:
6 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Debug-mode check added: optimized keyed store of a smi on x64 is done to a entry containing a smi. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19389

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M src/x64/lithium-codegen-x64.cc View 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Igor Sheludko
PTAL
6 years, 10 months ago (2014-02-14 16:17:36 UTC) #1
Toon Verwaest
lgtm
6 years, 10 months ago (2014-02-14 16:32:01 UTC) #2
Igor Sheludko
6 years, 10 months ago (2014-02-14 16:42:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19389 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698