Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 1670613002: Silence libtool warning when building libcrnet_standalone.a. (Closed)

Created:
4 years, 10 months ago by sdefresne
Modified:
4 years, 10 months ago
Reviewers:
droger
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Silence libtool warning when building libcrnet_standalone.a. Port code from tools/gyp/pylib/gyp/mac_tool.py to silence libtool warning to ios/build/packaging/link_dependencies.py. Add dependency on ios/build/packaging/link_dependencies.py for target that invoke it so that they are rebuilt when the script is updated. BUG=None Committed: https://crrev.com/db4a8df70e3521a6d555723356bdae37f95d7ff6 Cr-Commit-Position: refs/heads/master@{#373784}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove libtool_re5 use #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M ios/build/packaging/link_dependencies.py View 1 2 chunks +10 lines, -2 lines 0 comments Download
M ios/crnet/crnet_pack.gyp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
sdefresne
Please take a look.
4 years, 10 months ago (2016-02-04 17:35:15 UTC) #2
droger
https://codereview.chromium.org/1670613002/diff/1/ios/build/packaging/link_dependencies.py File ios/build/packaging/link_dependencies.py (right): https://codereview.chromium.org/1670613002/diff/1/ios/build/packaging/link_dependencies.py#newcode137 ios/build/packaging/link_dependencies.py:137: if not libtool_re.match(line) and not libtool_re5.match(line): Where is libtool_re5 ...
4 years, 10 months ago (2016-02-05 09:08:50 UTC) #4
sdefresne
PTAL https://codereview.chromium.org/1670613002/diff/1/ios/build/packaging/link_dependencies.py File ios/build/packaging/link_dependencies.py (right): https://codereview.chromium.org/1670613002/diff/1/ios/build/packaging/link_dependencies.py#newcode137 ios/build/packaging/link_dependencies.py:137: if not libtool_re.match(line) and not libtool_re5.match(line): On 2016/02/05 ...
4 years, 10 months ago (2016-02-05 09:58:57 UTC) #5
droger
lgtm
4 years, 10 months ago (2016-02-05 10:06:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1670613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1670613002/20001
4 years, 10 months ago (2016-02-05 10:10:28 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-05 11:07:56 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 11:08:51 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/db4a8df70e3521a6d555723356bdae37f95d7ff6
Cr-Commit-Position: refs/heads/master@{#373784}

Powered by Google App Engine
This is Rietveld 408576698