Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 167053004: [cc] cleanup: remove useless comments in UpdateStateOnActivation() (Closed)

Created:
6 years, 10 months ago by simonhong
Modified:
6 years, 10 months ago
Reviewers:
tfarina, brianderson
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

[cc] cleanup: remove useless comments in UpdateStateOnActivation() BUG=None TEST=None, no functional changes. R=brianderson@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252203

Patch Set 1 #

Patch Set 2 : Remove useless comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M cc/scheduler/scheduler_state_machine.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
simonhong
PTAL!
6 years, 10 months ago (2014-02-19 07:28:42 UTC) #1
brianderson
These look like useless comments. Can you remove them instead? I probably added them in ...
6 years, 10 months ago (2014-02-19 18:14:20 UTC) #2
simonhong
On 2014/02/19 18:14:20, Brian Anderson wrote: > These look like useless comments. Can you remove ...
6 years, 10 months ago (2014-02-19 19:35:45 UTC) #3
brianderson
Thanks! lgtm.
6 years, 10 months ago (2014-02-19 21:59:39 UTC) #4
simonhong
The CQ bit was checked by simonhong@chromium.org
6 years, 10 months ago (2014-02-19 22:01:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhong@chromium.org/167053004/50001
6 years, 10 months ago (2014-02-19 22:14:38 UTC) #6
tfarina
The CQ bit was unchecked by tfarina@chromium.org
6 years, 10 months ago (2014-02-19 22:25:42 UTC) #7
tfarina
Please, fix your CL description before landing (to reflect your actual changes). Thanks.
6 years, 10 months ago (2014-02-19 22:26:21 UTC) #8
simonhong
On 2014/02/19 22:26:21, tfarina wrote: > Please, fix your CL description before landing (to reflect ...
6 years, 10 months ago (2014-02-19 22:29:33 UTC) #9
simonhong
On 2014/02/19 22:26:21, tfarina wrote: > Please, fix your CL description before landing (to reflect ...
6 years, 10 months ago (2014-02-19 22:29:35 UTC) #10
simonhong
The CQ bit was checked by simonhong@chromium.org
6 years, 10 months ago (2014-02-19 22:30:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhong@chromium.org/167053004/50001
6 years, 10 months ago (2014-02-20 00:45:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhong@chromium.org/167053004/50001
6 years, 10 months ago (2014-02-20 03:21:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhong@chromium.org/167053004/50001
6 years, 10 months ago (2014-02-20 08:44:52 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhong@chromium.org/167053004/50001
6 years, 10 months ago (2014-02-20 12:19:14 UTC) #15
commit-bot: I haz the power
6 years, 10 months ago (2014-02-20 13:00:53 UTC) #16
Message was sent while issue was closed. 
Change committed as 252203

Powered by Google App Engine
This is Rietveld 408576698