android envsetup: Stop adding build-tools dir (aidl, aapt, dx, dexdump) to PATH.

android envsetup: Stop adding build-tools dir (aidl, aapt, dx, dexdump) to PATH.

It looks like everything looks qualified paths to reference the binaries
in this folder already.

BUG=330631
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251493

[Nico, 2014-02-14 20:07:28]

(Looks like build/android/pylib/utils/apk_helper.py still calls aapt
directly – I'll fix that in a separate CL and not land this change here
before the other change is in.)


On Fri, Feb 14, 2014 at 11:18 AM, <thakis@chromium.org> wrote:

> Reviewers: Yaron,
>
> Description:
> android envsetup: Stop adding build-tools dir (aidl, aapt, etc) to PATH.
>
> It looks like everything looks qualified paths to reference the binaries
> in this folder already.
>
> BUG=330631
>
> Please review this at https://codereview.chromium.org/167053003/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+0, -2 lines):
>   M build/android/envsetup_functions.sh
>
>
> Index: build/android/envsetup_functions.sh
> diff --git a/build/android/envsetup_functions.sh b/build/android/envsetup_
> functions.sh
> index 2a89cc8e660839caf716db3b6c310c6136e44a49..
> 5a37e159bc797e01e7d9d8f5a10c12c5cd1383ea 100755
> --- a/build/android/envsetup_functions.sh
> +++ b/build/android/envsetup_functions.sh
> @@ -17,8 +17,6 @@ common_vars_defines() {
>    # Add Android SDK tools to system path.
>    export PATH=$PATH:${ANDROID_SDK_ROOT}/tools
>    export PATH=$PATH:${ANDROID_SDK_ROOT}/platform-tools
> -  export PATH=$PATH:${ANDROID_SDK_ROOT}/build-tools/\
> -${ANDROID_SDK_BUILD_TOOLS_VERSION}
>
>    # Add Chromium Android development scripts to system path.
>    # Must be after CHROME_SRC is set.
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Yaron, 2014-02-14 21:47:56]

lgtm when that lands


On Fri, Feb 14, 2014 at 12:07 PM, Nico Weber <thakis@chromium.org> wrote:

> (Looks like build/android/pylib/utils/apk_helper.py still calls aapt
> directly – I'll fix that in a separate CL and not land this change here
> before the other change is in.)
>
>
> On Fri, Feb 14, 2014 at 11:18 AM, <thakis@chromium.org> wrote:
>
>> Reviewers: Yaron,
>>
>> Description:
>> android envsetup: Stop adding build-tools dir (aidl, aapt, etc) to PATH.
>>
>> It looks like everything looks qualified paths to reference the binaries
>> in this folder already.
>>
>> BUG=330631
>>
>> Please review this at https://codereview.chromium.org/167053003/
>>
>> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>>
>> Affected files (+0, -2 lines):
>>   M build/android/envsetup_functions.sh
>>
>>
>> Index: build/android/envsetup_functions.sh
>> diff --git a/build/android/envsetup_functions.sh
>> b/build/android/envsetup_functions.sh
>> index 2a89cc8e660839caf716db3b6c310c6136e44a49..
>> 5a37e159bc797e01e7d9d8f5a10c12c5cd1383ea 100755
>> --- a/build/android/envsetup_functions.sh
>> +++ b/build/android/envsetup_functions.sh
>> @@ -17,8 +17,6 @@ common_vars_defines() {
>>    # Add Android SDK tools to system path.
>>    export PATH=$PATH:${ANDROID_SDK_ROOT}/tools
>>    export PATH=$PATH:${ANDROID_SDK_ROOT}/platform-tools
>> -  export PATH=$PATH:${ANDROID_SDK_ROOT}/build-tools/\
>> -${ANDROID_SDK_BUILD_TOOLS_VERSION}
>>
>>    # Add Chromium Android development scripts to system path.
>>    # Must be after CHROME_SRC is set.
>>
>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2014-02-15 00:24:11]

(Prerequisite landed in r251452)

[Nico, 2014-02-15 02:01:49]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-02-15 02:03:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/167053003/1

[commit-bot: I haz the power, 2014-02-15 03:37:49]

Change committed as 251493