Add NOP to ARM IR lowering.

src/IceInstARM32.cpp

 //===- subzero/src/IceInstARM32.cpp - ARM32 instruction implementation ----===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 1076 matching lines @@
 
 InstARM32Vabs::InstARM32Vabs(Cfg *Func, Variable *Dest, Variable *Src,
                              CondARM32::Cond Predicate)
     : InstARM32Pred(Func, InstARM32::Vabs, 1, Dest, Predicate) {
   addSource(Src);
 }
 
 InstARM32Dmb::InstARM32Dmb(Cfg *Func)
     : InstARM32Pred(Func, InstARM32::Dmb, 0, nullptr, CondARM32::AL) {}
 
+InstARM32Nop::InstARM32Nop(Cfg *Func)

[Jim Stichnoth, 2016/02/08 18:17:50]

Should nop (and dmb above) be inserted into the list more alphabetically?

[Karl, 2016/02/09 21:10:01]

Really? Where do you see sorting? For the most part, I have no idea how this
file was sorted. However, I will at least sort this short list of constructors.

+    : InstARM32Pred(Func, InstARM32::Nop, 0, nullptr, CondARM32::AL) {}
+
 // ======================== Dump routines ======================== //
 
 // Two-addr ops
 template <> const char *InstARM32Movt::Opcode = "movt";
 // Unary ops
 template <> const char *InstARM32Movw::Opcode = "movw";
 template <> const char *InstARM32Clz::Opcode = "clz";
 template <> const char *InstARM32Mvn::Opcode = "mvn";
 template <> const char *InstARM32Rbit::Opcode = "rbit";
 template <> const char *InstARM32Rev::Opcode = "rev";
@@ skipping 1184 matching lines @@
     emitUsingTextFixup(Func);
 }
 
 void InstARM32Dmb::dump(const Cfg *Func) const {
   if (!BuildDefs::dump())
     return;
   Func->getContext()->getStrDump() << "dmb\t"
                                       "sy";
 }
 
+void InstARM32Nop::emit(const Cfg *Func) const {
+  if (!BuildDefs::dump())
+    return;
+  assert(getSrcSize() == 0);
+  Func->getContext()->getStrEmit() << "\t"
+                                   << "nop";
+}
+
+void InstARM32Nop::emitIAS(const Cfg *Func) const {
+  assert(getSrcSize() == 0);
+  Func->getAssembler<ARM32::AssemblerARM32>()->nop();
+}
+
+void InstARM32Nop::dump(const Cfg *Func) const {
+  if (!BuildDefs::dump())
+    return;
+  assert(getSrcSize() == 0);
+  Func->getContext()->getStrDump() << "\t"

[Jim Stichnoth, 2016/02/08 18:17:50]

dump() doesn't usually prepend a tab character.

[Karl, 2016/02/09 21:10:01]

Done.

+                                   << "nop";
+}
+
 void OperandARM32Mem::emit(const Cfg *Func) const {
   if (!BuildDefs::dump())
     return;
   Ostream &Str = Func->getContext()->getStrEmit();
   Str << "[";
   getBase()->emit(Func);
   switch (getAddrMode()) {
   case PostIndex:
   case NegPostIndex:
     Str << "]";
@@ skipping 230 matching lines @@
 
 template class InstARM32FourAddrGPR<InstARM32::Mla>;
 template class InstARM32FourAddrGPR<InstARM32::Mls>;
 
 template class InstARM32CmpLike<InstARM32::Cmn>;
 template class InstARM32CmpLike<InstARM32::Cmp>;
 template class InstARM32CmpLike<InstARM32::Tst>;
 
 } // end of namespace ARM32
 } // end of namespace Ice