Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1670383002: [Autofill] Fix Walgreens' address autofill. (Closed)

Created:
4 years, 10 months ago by Toyama
Modified:
4 years, 10 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Walgreens' address autofill. BUG=584787 TEST=FormStructureBrowserTest Committed: https://crrev.com/f7e90433ee8ec70548da25960e7a79bd48766e89 Cr-Commit-Position: refs/heads/master@{#373945}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+695 lines, -3 lines) Patch
A chrome/test/data/autofill/heuristics/input/28_checkout_walgreens.com.html View 1 chunk +682 lines, -0 lines 0 comments Download
A chrome/test/data/autofill/heuristics/output/28_checkout_walgreens.com.out View 1 chunk +10 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_regex_constants.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Toyama
Please take a look, Math!
4 years, 10 months ago (2016-02-05 21:24:24 UTC) #4
Mathieu
lgtm
4 years, 10 months ago (2016-02-05 21:34:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1670383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1670383002/1
4 years, 10 months ago (2016-02-05 21:37:33 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-05 23:29:31 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 23:31:05 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f7e90433ee8ec70548da25960e7a79bd48766e89
Cr-Commit-Position: refs/heads/master@{#373945}

Powered by Google App Engine
This is Rietveld 408576698