Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: chrome/browser/extensions/api/media_galleries_private/media_galleries_eject_apitest.cc

Issue 16703025: [StorageMonitor] Move StorageMonitor ownership to BrowserProcessImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Catch up to SystemInfoStorage eject test Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/media_galleries_private/media_galleries_eject_apitest.cc
diff --git a/chrome/browser/extensions/api/media_galleries_private/media_galleries_eject_apitest.cc b/chrome/browser/extensions/api/media_galleries_private/media_galleries_eject_apitest.cc
index 32055eba33d299bbb283dae55edf0fc26c654136..ba8407ea96653e26363aef7c506750b868bb2a3b 100644
--- a/chrome/browser/extensions/api/media_galleries_private/media_galleries_eject_apitest.cc
+++ b/chrome/browser/extensions/api/media_galleries_private/media_galleries_eject_apitest.cc
@@ -53,7 +53,9 @@ base::FilePath::CharType kDevicePath[] = FILE_PATH_LITERAL("/qux");
class MediaGalleriesPrivateEjectApiTest : public ExtensionApiTest {
public:
- MediaGalleriesPrivateEjectApiTest() : device_id_(GetDeviceId()) {}
+ MediaGalleriesPrivateEjectApiTest()
+ : device_id_(GetDeviceId()),
+ monitor_(NULL) {}
virtual ~MediaGalleriesPrivateEjectApiTest() {}
protected:
@@ -64,6 +66,11 @@ class MediaGalleriesPrivateEjectApiTest : public ExtensionApiTest {
kTestExtensionId);
}
+ virtual void SetUpOnMainThread() OVERRIDE {
+ monitor_ = chrome::test::TestStorageMonitor::CreateForBrowserTests();
+ ExtensionApiTest::SetUpOnMainThread();
+ }
+
content::RenderViewHost* GetHost() {
const extensions::Extension* extension =
LoadExtension(test_data_dir_.AppendASCII(kTestExtensionPath));
@@ -103,6 +110,8 @@ class MediaGalleriesPrivateEjectApiTest : public ExtensionApiTest {
protected:
const std::string device_id_;
+ chrome::test::TestStorageMonitor* monitor_;
+
private:
DISALLOW_COPY_AND_ASSIGN(MediaGalleriesPrivateEjectApiTest);
};
@@ -113,11 +122,6 @@ class MediaGalleriesPrivateEjectApiTest : public ExtensionApiTest {
///////////////////////////////////////////////////////////////////////////////
IN_PROC_BROWSER_TEST_F(MediaGalleriesPrivateEjectApiTest, EjectTest) {
- scoped_ptr<chrome::test::TestStorageMonitor> monitor(
- chrome::test::TestStorageMonitor::CreateForBrowserTests());
- monitor->Init();
- monitor->MarkInitialized();
-
content::RenderViewHost* host = GetHost();
ExecuteCmdAndCheckReply(host, kAddAttachListenerCmd, kAddAttachListenerOk);
@@ -130,18 +134,13 @@ IN_PROC_BROWSER_TEST_F(MediaGalleriesPrivateEjectApiTest, EjectTest) {
EXPECT_TRUE(attach_finished_listener.WaitUntilSatisfied());
ExecuteCmdAndCheckReply(host, kEjectTestCmd, kEjectListenerOk);
- EXPECT_EQ(device_id_, monitor->ejected_device());
+ EXPECT_EQ(device_id_, monitor_->ejected_device());
Detach();
}
IN_PROC_BROWSER_TEST_F(MediaGalleriesPrivateEjectApiTest, EjectBadDeviceTest) {
- scoped_ptr<chrome::test::TestStorageMonitor> monitor(
- chrome::test::TestStorageMonitor::CreateForBrowserTests());
- monitor->Init();
- monitor->MarkInitialized();
-
ExecuteCmdAndCheckReply(GetHost(), kEjectFailTestCmd, kEjectFailListenerOk);
- EXPECT_EQ("", monitor->ejected_device());
+ EXPECT_EQ("", monitor_->ejected_device());
}

Powered by Google App Engine
This is Rietveld 408576698