Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2789)

Unified Diff: chrome/browser/storage_monitor/test_storage_monitor.h

Issue 16703025: [StorageMonitor] Move StorageMonitor ownership to BrowserProcessImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/storage_monitor/test_storage_monitor.h
diff --git a/chrome/browser/storage_monitor/test_storage_monitor.h b/chrome/browser/storage_monitor/test_storage_monitor.h
index 6408e6657c9423f2dcb42d1c6a0321d79806ad12..635ef5889b8cb1349fa7dfcbbe3ca9510c4ffa8e 100644
--- a/chrome/browser/storage_monitor/test_storage_monitor.h
+++ b/chrome/browser/storage_monitor/test_storage_monitor.h
@@ -21,10 +21,20 @@ class TestStorageMonitor : public chrome::StorageMonitor {
void MarkInitialized();
- // Will create a new testing implementation for browser tests,
- // taking care to deal with the existing singleton correctly.
+ // Create an initialize a new TestStorageMonitor and install it
vandebo (ex-Chrome) 2013/07/10 16:57:45 an -> and
Greg Billock 2013/07/10 21:11:16 Done.
+ // in the TestingBrowserProcess.
+ static TestStorageMonitor* Create();
+
+ // Create an initialize a new TestStorageMonitor, and install it
vandebo (ex-Chrome) 2013/07/10 16:57:45 an -> and
Greg Billock 2013/07/10 21:11:16 Done.
+ // in the BrowserProcessImpl. (Browser tests use the production browser
+ // process implementation.)
static TestStorageMonitor* CreateForBrowserTests();
+ static void RemoveSingleton();
vandebo (ex-Chrome) 2013/07/10 16:57:45 Add comment
Greg Billock 2013/07/10 21:11:16 Done.
+
+ // Synchronously initialize the current storage monitor.
+ static void SyncInitialize();
+
virtual bool GetStorageInfoForPath(
const base::FilePath& path,
StorageInfo* device_info) const OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698