Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: chrome/browser/storage_monitor/storage_monitor_win.h

Issue 16703025: [StorageMonitor] Move StorageMonitor ownership to BrowserProcessImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/storage_monitor/storage_monitor_win.h
diff --git a/chrome/browser/storage_monitor/storage_monitor_win.h b/chrome/browser/storage_monitor/storage_monitor_win.h
index 6472c0df6a2e2383f377c52229fb245511fe87c6..fd876d52247c75195adad56d96b99dc0ecd0def3 100644
--- a/chrome/browser/storage_monitor/storage_monitor_win.h
+++ b/chrome/browser/storage_monitor/storage_monitor_win.h
@@ -25,10 +25,11 @@ class VolumeMountWatcherWin;
class StorageMonitorWin : public StorageMonitor {
public:
- // Creates an instance of StorageMonitorWin. Should only be called by browser
- // start up code. Use GetInstance() instead.
- static StorageMonitorWin* Create();
-
+ // To support unit tests, this constructor takes |volume_mount_watcher| and
+ // |portable_device_watcher| objects. These params are either constructed in
+ // unit tests or in StorageMonitorWin::Create() function.
+ StorageMonitorWin(VolumeMountWatcherWin* volume_mount_watcher,
+ PortableDeviceWatcherWin* portable_device_watcher);
virtual ~StorageMonitorWin();
// Must be called after the file thread is created.
@@ -50,12 +51,6 @@ class StorageMonitorWin : public StorageMonitor {
class PortableDeviceNotifications;
friend class test::TestStorageMonitorWin;
- // To support unit tests, this constructor takes |volume_mount_watcher| and
- // |portable_device_watcher| objects. These params are either constructed in
- // unit tests or in StorageMonitorWin::Create() function.
- StorageMonitorWin(VolumeMountWatcherWin* volume_mount_watcher,
- PortableDeviceWatcherWin* portable_device_watcher);
-
// Gets the removable storage information given a |device_path|. On success,
// returns true and fills in |info|.
bool GetDeviceInfo(const base::FilePath& device_path,

Powered by Google App Engine
This is Rietveld 408576698