[StorageMonitor] Move StorageMonitor ownership to BrowserProcessImpl

chrome/browser/browser_process_impl.cc

Index: chrome/browser/browser_process_impl.cc
diff --git a/chrome/browser/browser_process_impl.cc b/chrome/browser/browser_process_impl.cc
index 6673807f1b4a8ba24337e87802d4c40513f2125a..c6d099ac5750f27c8af0b565fd4337814a2e4e8e 100644
--- a/chrome/browser/browser_process_impl.cc
+++ b/chrome/browser/browser_process_impl.cc
@@ -61,6 +61,7 @@
 #include "chrome/browser/safe_browsing/safe_browsing_service.h"
 #include "chrome/browser/shell_integration.h"
 #include "chrome/browser/status_icons/status_tray.h"
+#include "chrome/browser/storage_monitor/storage_monitor.h"
 #include "chrome/browser/thumbnails/render_widget_snapshot_taker.h"
 #include "chrome/browser/ui/bookmarks/bookmark_prompt_controller.h"
 #include "chrome/browser/ui/browser_finder.h"
@@ -106,7 +107,7 @@
 #include "ui/aura/env.h"
 #endif
 
-#if !defined(OS_ANDROID)
+#if !defined(OS_ANDROID) && !defined(OS_IOS)
 #include "chrome/browser/media_galleries/media_file_system_registry.h"
 #endif
 
@@ -274,6 +275,15 @@ void BrowserProcessImpl::StartTearDown() {
 #endif
 
   platform_part()->StartTearDown();
+
+#if !defined(OS_ANDROID) && !defined(OS_IOS)

[vandebo (ex-Chrome), 2013/07/09 15:38:12]

Without any other context, I would guess this should go between
ExtensionRendererState shutdown and MessageCenter shutdown.  If the names
suggest the right thing to my pattern matching, MediaFileSystemRegistry is
listening for stuff from MessageCenter.

[Greg Billock, 2013/07/09 17:35:21]

Is it? OK, moved.

[vandebo (ex-Chrome), 2013/07/09 21:14:11]

content::NOTIFICATION_RENDERER_PROCESS_TERMINATED,
content::NOTIFICATION_WEB_CONTENTS_DESTROYED, etc eventually come from
MessageCenter, right?

[Greg Billock, 2013/07/09 21:29:06]

Those are through the NotificationService. Looks like MessageCenter is the UI
facility to display user-facing notifications. The notification service gets
destroyed in the browser main chain, in BrowserMainRunner::Shutdown

+  media_file_system_registry_.reset();
+  // Delete |storage_monitor_| now. Otherwise the FILE thread would be gone
+  // when we try to release it in the dtor and Valgrind would report a
+  // leak on almost every single browser_test.
+  // TODO(gbillock): Make this unnecessary.
+  storage_monitor_.reset();
+#endif
 }
 
 void BrowserProcessImpl::PostDestroyThreads() {
@@ -619,9 +629,24 @@ BookmarkPromptController* BrowserProcessImpl::bookmark_prompt_controller() {
 #endif
 }
 
+chrome::StorageMonitor* BrowserProcessImpl::storage_monitor() {
+#if defined(OS_ANDROID) || defined(OS_IOS)
+  return NULL;
+#else
+  return storage_monitor_.get();
+#endif
+}
+
+void BrowserProcessImpl::set_storage_monitor_for_test(
+    scoped_ptr<chrome::StorageMonitor> monitor) {
+#if !defined(OS_ANDROID) && !defined(OS_IOS)
+  storage_monitor_ = monitor.Pass();
+#endif
+}
+
 chrome::MediaFileSystemRegistry*
 BrowserProcessImpl::media_file_system_registry() {
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID) || defined(OS_IOS)
     return NULL;
 #else
   if (!media_file_system_registry_)
@@ -910,6 +935,10 @@ void BrowserProcessImpl::PreMainMessageLoopRun() {
   }
 #endif
 
+#if !defined(OS_ANDROID) && !defined(OS_IOS)
+  storage_monitor_.reset(chrome::StorageMonitor::Create());

[vandebo (ex-Chrome), 2013/07/09 15:38:12]

Why not create this on first access like MediaFileSystemRegistry ?

[Greg Billock, 2013/07/09 17:35:21]

My aim here is to maintain exactly the same startup/shutdown sequence we have
now. I do think we want to change it around -- create on first access and
destroy on BrowserProcess destruction.

+#endif
+
 #if defined(OS_MACOSX)
   app_shim_host_manager_.reset(new AppShimHostManager);
   AppListService::InitAll(NULL);