chrome/browser/storage_monitor/storage_monitor_win_unittest.cc - Issue 16703025: [StorageMonitor] Move StorageMonitor ownership to BrowserProcessImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/storage_monitor/storage_monitor_win_unittest.cc

Issue 16703025: [StorageMonitor] Move StorageMonitor ownership to BrowserProcessImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/storage_monitor/storage_monitor.h ('K') | « chrome/browser/storage_monitor/storage_monitor_win.cc ('k') | chrome/browser/storage_monitor/test_storage_monitor.h » ('j') | chrome/browser/storage_monitor/test_storage_monitor.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/storage_monitor/storage_monitor_win_unittest.cc

diff --git a/chrome/browser/storage_monitor/storage_monitor_win_unittest.cc b/chrome/browser/storage_monitor/storage_monitor_win_unittest.cc

index 4e9ad7ec6ca10a8d69c4d6423a6c689ab4e1b44a..46b0ae980d9eab2798b7c2d597bbde9f7a6e0156 100644

--- a/chrome/browser/storage_monitor/storage_monitor_win_unittest.cc

+++ b/chrome/browser/storage_monitor/storage_monitor_win_unittest.cc

@@ -19,6 +19,7 @@

#include "chrome/browser/storage_monitor/storage_info.h"

#include "chrome/browser/storage_monitor/storage_monitor_win.h"

#include "chrome/browser/storage_monitor/test_portable_device_watcher_win.h"

+#include "chrome/browser/storage_monitor/test_storage_monitor.h"

#include "chrome/browser/storage_monitor/test_storage_monitor_win.h"

#include "chrome/browser/storage_monitor/test_volume_mount_watcher_win.h"

#include "chrome/browser/storage_monitor/volume_mount_watcher_win.h"

@@ -86,6 +87,7 @@ StorageMonitorWinTest::~StorageMonitorWinTest() {

void StorageMonitorWinTest::SetUp() {

ASSERT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ test::TestStorageMonitor::RemoveSingleton();

Lei Zhang 2013/07/02 23:16:57 Is this needed in unit tests where there's probabl

Greg Billock 2013/07/03 17:49:17 In unit tests you get the TestingBrowserProcess as

volume_mount_watcher_ = new TestVolumeMountWatcherWin;

monitor_.reset(new TestStorageMonitorWin(volume_mount_watcher_,

new TestPortableDeviceWatcherWin));