[StorageMonitor] Move StorageMonitor ownership to BrowserProcessImpl

chrome/browser/storage_monitor/storage_monitor_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/storage_monitor/storage_monitor_win.h"
 
 #include <windows.h>
 #include <dbt.h>
 #include <fileapi.h>
 
 #include "base/win/wrapped_window_proc.h"
 #include "chrome/browser/storage_monitor/portable_device_watcher_win.h"
 #include "chrome/browser/storage_monitor/removable_device_constants.h"
 #include "chrome/browser/storage_monitor/storage_info.h"
 #include "chrome/browser/storage_monitor/volume_mount_watcher_win.h"
 
 namespace chrome {
 
 // StorageMonitorWin -------------------------------------------------------
 
-// static
-StorageMonitorWin* StorageMonitorWin::Create() {
-  return new StorageMonitorWin(new VolumeMountWatcherWin(),
-                               new PortableDeviceWatcherWin());
-}
-
 StorageMonitorWin::StorageMonitorWin(
     VolumeMountWatcherWin* volume_mount_watcher,
     PortableDeviceWatcherWin* portable_device_watcher)
     : window_class_(0),
       instance_(NULL),
       window_(NULL),
       volume_mount_watcher_(volume_mount_watcher),
       portable_device_watcher_(portable_device_watcher) {
   DCHECK(volume_mount_watcher_);
   DCHECK(portable_device_watcher_);
@@ skipping 123 matching lines @@
   // function when we have the functionality to add a sub directory of
   // portable device as a media gallery.
   return volume_mount_watcher_->GetDeviceInfo(device_path, info);
 }
 
 void StorageMonitorWin::OnDeviceChange(UINT event_type, LPARAM data) {
   volume_mount_watcher_->OnWindowMessage(event_type, data);
   portable_device_watcher_->OnWindowMessage(event_type, data);
 }
 
+StorageMonitor* StorageMonitor::Create() {
+  return new StorageMonitorWin(new VolumeMountWatcherWin(),

[vandebo (ex-Chrome), 2013/07/10 16:57:45]

Is this what you mean by the factory?  Would making the constructor protected
solve the problem?

[Greg Billock, 2013/07/10 21:11:16]

Yes, this is the windows factory impl. You mean make the StorageMonitor
constructor protected? It is now.

[vandebo (ex-Chrome), 2013/07/11 15:53:00]

The StorageMonitorWin constructor is currently public.

+                               new PortableDeviceWatcherWin());
+}
+
 }  // namespace chrome