Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 16703024: Fixes microbench format change caused by r9417. (Closed)

Created:
7 years, 6 months ago by benchen
Modified:
7 years, 6 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com, skiabot_google.com, bsalomon
Visibility:
Public.

Description

Fixes microbench format change caused by r9417. r9417 introduced extra line breaks between different configs for a bench. This reverts the outputs to the previous one-line format. Committed: https://code.google.com/p/skia/source/detail?r=9528

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M bench/benchmain.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
benchen
We need this potentially temporary fix even if we decide to switch to json all ...
7 years, 6 months ago (2013-06-12 14:30:52 UTC) #1
robertphillips
lgtm
7 years, 6 months ago (2013-06-12 14:41:01 UTC) #2
benchen
7 years, 6 months ago (2013-06-12 14:45:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r9528 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698