lib/src/scope.dart - Issue 1670283002: add sendRequest to VMIsolateRef

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/scope.dart

Issue 1670283002: add sendRequest to VMIsolateRef Base URL: git@github.com:yjbanov/vm_service_client.git@master

Patch Set: onServiceExtensionAdded; Future<Object> Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/scope.dart

diff --git a/lib/src/scope.dart b/lib/src/scope.dart

index 24997c6228331b49ebaa500e3cd8c7ae22070481..3a01ab545c92b167e27fd3998435a3d2a61aa959 100644

--- a/lib/src/scope.dart

+++ b/lib/src/scope.dart

@@ -46,9 +46,9 @@ class Scope {

/// Calls an isolate-scoped RPC named [method] with [params].

///

/// This always adds the `isolateId` parameter to the RPC.

- Future<Map> sendRequest(String method, [Map<String, Object> params]) async {

+ Future<Object> sendRequest(String method, [Map<String, Object> params]) async {

nweiz 2016/02/16 22:03:20 Nit: long line

yjbanov 2016/02/16 22:31:49 Done.

var allParams = {"isolateId": isolateId}..addAll(params ?? {});

- return (await peer.sendRequest(method, allParams)) as Map;

+ return await peer.sendRequest(method, allParams);

}

/// Evaluates [expression] in the context of the object identified by [id].